Skip to content

[No QA] Help site updates for several product changes#85727

Merged
greg-schroeder merged 6 commits intomainfrom
helpsite-multiple-changes
Mar 25, 2026
Merged

[No QA] Help site updates for several product changes#85727
greg-schroeder merged 6 commits intomainfrom
helpsite-multiple-changes

Conversation

@stephanieelliott
Copy link
Copy Markdown
Contributor

@stephanieelliott stephanieelliott commented Mar 19, 2026

@stephanieelliott stephanieelliott self-assigned this Mar 19, 2026
@stephanieelliott stephanieelliott requested a review from a team March 19, 2026 02:57
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 19, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @greg-schroeder

@melvin-bot melvin-bot bot requested review from greg-schroeder and removed request for a team March 19, 2026 02:57
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 19, 2026

@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions github-actions bot changed the title Help site updates for several product changes [No QA] Help site updates for several product changes Mar 19, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 19, 2026

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes targeted updates across three help articles to reflect product changes: a new Chase-specific FAQ, updated SmartScan instructions (icon naming and navigation context), expanded bulk upload options, and improved navigation phrasing for report creation. The changes are generally well-written and improve accuracy, but several issues need attention before merge.

Scores Summary

  • Readability: 7/10 - The new content is clearly written and scannable. However, the bulk upload intro sentence ("You can upload receipts using any of the following methods:") implies multiple methods follow, but only one numbered list is provided. An extra blank line is also introduced. These small issues reduce clarity.
  • AI Readiness: 8/10 - The new FAQ heading ("Why is my Chase bank account number different after connecting?") is well-formed with a question word, feature name, and specific intent. Navigation context added to SmartScan web steps improves discoverability. No metadata or heading structure issues are introduced.
  • Style Compliance: 6/10 - Several governance deviations are present in the diff: inconsistent use of "green" descriptor across the same file, capitalization mismatch ("Web"/"Mobile" vs. governance-prescribed "web"/"mobile"), a trailing space, and content duplication with an existing FAQ entry.

Key Findings

Issues to address:

  1. Capitalization mismatch in navigation phrasing (Create-and-Submit-Reports.md, line 14): The diff introduces "on the left on Web, on the bottom on Mobile" with uppercase "Web" and "Mobile." The governance file (HELPSITE_NAMING_CONVENTIONS.md, line 127) specifies the exact pattern: "on the left on web, on the bottom on mobile" (lowercase). This must match exactly per the Deterministic Writing Rule.

  2. Inconsistent "green" descriptor removal (Create-an-Expense.md): The diff removes "green" from the mobile camera icon instruction (line 31) but retains "green" in the web Scan icon instruction (line 37: "click the green Scan icon"). Within the same file, the unchanged line 107 ("tap the green camera icon") also retains "green." If "green" is being removed to reflect a UI change on mobile, the web instruction should be evaluated for consistency. If the icon is still green on web, this is acceptable but should be confirmed.

  3. Misleading intro sentence for bulk upload (Create-an-Expense.md, lines 117-118): The added sentence "You can upload receipts using any of the following methods:" implies multiple methods will be listed, but only one sequential flow follows. This should either be reworded (e.g., "To bulk upload receipts:") or additional methods should be documented if they exist.

  4. Potential content duplication (Connect-Personal-Bank-Account.md): The new FAQ "Why is my Chase bank account number different after connecting?" overlaps significantly with the existing FAQ at line 50: "Why don't the account number and routing number in Expensify match what's on my bank statement?" which already mentions Chase and tokenized numbers. Consider merging these into a single, comprehensive FAQ entry to avoid confusing users and AI retrieval systems with near-duplicate content.

  5. Trailing whitespace (Create-an-Expense.md, line 37): There is a trailing space after "click the green Scan icon." -- minor formatting issue.

  6. Extra blank line (Create-an-Expense.md, line 122): An extra blank line is introduced after the bulk upload steps, before the --- separator. This is a minor formatting inconsistency.

Positive aspects:

  • The new Chase FAQ heading is well-structured with a question word and specific feature name, making it search-friendly and AI-retrievable.
  • Adding navigation context to the SmartScan web instruction ("In the navigation tabs on the left") follows the Navigation Instruction Standards and improves user orientation.
  • Correcting "scan" to "Scan" and "button" to "icon" improves UI terminology accuracy.
  • The navigation phrasing added in Create-and-Submit-Reports.md follows the correct unified format pattern from the governance docs (aside from the capitalization issue).
  • Adding the Home page as an alternative location for bulk upload reflects a genuine product update.

Recommendations

  1. [Must fix] Change "Web" and "Mobile" to lowercase "web" and "mobile" in Create-and-Submit-Reports.md to match the exact governance pattern.
  2. [Should fix] Reword the bulk upload intro sentence to avoid implying multiple methods when only one is described.
  3. [Should fix] Evaluate whether the new Chase FAQ should be merged with the existing similar FAQ entry at line 50 of Connect-Personal-Bank-Account.md, or differentiate them more clearly.
  4. [Should fix] Confirm whether "green" should be removed from the web Scan icon instruction (line 37) to match the mobile change, or if the color difference is intentional per platform.
  5. [Minor] Remove the trailing space on line 37 and the extra blank line on line 122 of Create-an-Expense.md.

Files Reviewed

  • Connect-Personal-Bank-Account.md - New Chase FAQ added; well-written but overlaps with existing FAQ entry.
  • Create-an-Expense.md - SmartScan instructions updated with navigation context and icon naming corrections; bulk upload section expanded. Has inconsistency and misleading intro text.
  • Create-and-Submit-Reports.md - Navigation phrasing improved with platform context; needs capitalization fix to match governance standard.

Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce7c9d1f10

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@greg-schroeder
Copy link
Copy Markdown
Contributor

greg-schroeder commented Mar 25, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@greg-schroeder greg-schroeder merged commit fe2d384 into main Mar 25, 2026
14 checks passed
@greg-schroeder greg-schroeder deleted the helpsite-multiple-changes branch March 25, 2026 11:46
@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/greg-schroeder in version: 9.3.44-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/greg-schroeder in version: 9.3.47-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.3.48-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants