Skip to content

fix: android pressability issue with measureAsyncOnUI patch #85745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MelvinBot wants to merge 18 commits into
base: main
Choose a base branch
from
Open

fix: android pressability issue with measureAsyncOnUI patch #85745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ed7c567
fix: android pressability issue with measureAsyncOnUI patch
MelvinBot Mar 19, 2026
64d0f1c
Fix: correct hunk header line counts in react-native patch
MelvinBot Mar 19, 2026
aadf964
Fix: correct hunk header line counts in pressability patch
MelvinBot Mar 19, 2026
c0c7ceb
Merge branch 'claude-fixPressabilityNewArch-v2' of https://github.com…
MelvinBot Mar 19, 2026
8e92f4b
Fix incorrect hunk header line counts in pressability patch
MelvinBot Mar 19, 2026
3e42f9e
Merge remote-tracking branch 'origin/claude-fixPressabilityNewArch-v2…
MelvinBot Mar 19, 2026
be97dce
Fix: patch file hunk header integrity for RCTMountingManager.mm
MelvinBot Mar 19, 2026
0dfbaff
Fix: add measureAsyncOnUI fallback for test env and restore onShown type
MelvinBot Mar 19, 2026
858cb30
Fix: ESLint errors in ProductTrainingContext
MelvinBot Mar 19, 2026
5cbe2b5
Fix: replace deprecated ShadowNode::Shared with std::shared_ptr<const…
MelvinBot Mar 19, 2026
e6bf2ac
Fix: correct FabricUIManager import path in ReactNativeElement patch
MelvinBot Mar 19, 2026
eecbabf
Replace pressability new-arch patch with updated version
MelvinBot Mar 19, 2026
9256f73
Revert onShown changes — out of scope for this PR
MelvinBot Mar 19, 2026
a67e9a8
Fix: add fallback to measure() in Pressability patch for test environ…
MelvinBot Mar 19, 2026
4a22936
Merge remote-tracking branch 'origin/main' into claude-fixPressabilit…
MelvinBot Mar 19, 2026
3727148
Fix: update react-native patch context lines to match actual source
MelvinBot Mar 19, 2026
5c35595
Fix: correct FabricMountingManager.cpp hunk line number in patch 032
MelvinBot Mar 19, 2026
1c122a1
Fix: remove unnecessary RCTFabricSurface.h import from RCTMountingMan…
MelvinBot Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions patches/react-native/details.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,3 +238,9 @@
- Upstream PR/issue: https://github.com/facebook/react-native/pull/55934
- E/App issue: https://github.com/Expensify/App/issues/75120
- PR Introducing Patch: https://github.com/Expensify/App/pull/79962

### [react-native+0.83.1+032+fix-pressability-new-arch.patch](react-native+0.83.1+032+fix-pressability-new-arch.patch)

- Reason: Fixes an Android-specific issue (reproducible on certain Samsung models) where `onPress` events do not trigger for `Pressable` components when used inside a `Tooltip`. The root cause is that in the new architecture, `Pressability.measure()` reads stale layout information from the shadow tree instead of the actual native view hierarchy. This patch introduces a new `measureAsyncOnUI` method that measures the view asynchronously using the native layout hierarchy on the UI thread, bypassing stale shadow tree data.
- Upstream PR/issue: [facebook/react-native#51835](https://github.com/facebook/react-native/pull/51835)
- E/App issue: [#59953](https://github.com/Expensify/App/issues/59953)
Loading
Loading