Add last-12-months to search date filter presets#85756
Open
mhawryluk wants to merge 4 commits intoExpensify:mainfrom
Open
Add last-12-months to search date filter presets#85756mhawryluk wants to merge 4 commits intoExpensify:mainfrom
last-12-months to search date filter presets#85756mhawryluk wants to merge 4 commits intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index bba57482..437dabeb 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7296,8 +7296,9 @@ Fordern Sie Spesendetails wie Belege und Beschreibungen an, legen Sie Limits und
[CONST.SEARCH.DATE_PRESETS.NEVER]: 'Nie',
[CONST.SEARCH.DATE_PRESETS.LAST_MONTH]: 'Letzter Monat',
[CONST.SEARCH.DATE_PRESETS.THIS_MONTH]: 'Diesen Monat',
- [CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: 'Laufendes Jahr',
- [CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT]: 'Letzter Auszug',
+ [CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: 'Seit Jahresbeginn',
+ [CONST.SEARCH.DATE_PRESETS.LAST_12_MONTHS]: 'Letzte 12 Monate',
+ [CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT]: 'Letzte Abrechnung',
},
},
status: 'Status',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 45a5c138..cd668926 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7318,9 +7318,10 @@ Rendez obligatoires des informations de dépense comme les reçus et les descrip
on: (date?: string) => `Le ${date ?? ''}`,
presets: {
[CONST.SEARCH.DATE_PRESETS.NEVER]: 'Jamais',
- [CONST.SEARCH.DATE_PRESETS.LAST_MONTH]: 'Mois dernier',
+ [CONST.SEARCH.DATE_PRESETS.LAST_MONTH]: 'Le mois dernier',
[CONST.SEARCH.DATE_PRESETS.THIS_MONTH]: 'Ce mois-ci',
- [CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: 'Depuis le début de l’année',
+ [CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: 'Cumul annuel',
+ [CONST.SEARCH.DATE_PRESETS.LAST_12_MONTHS]: '12 derniers mois',
[CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT]: 'Dernier relevé',
},
},
diff --git a/src/languages/it.ts b/src/languages/it.ts
index e3696ebd..dc6a625c 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7282,9 +7282,10 @@ Richiedi dettagli sulle spese come ricevute e descrizioni, imposta limiti e valo
on: (date?: string) => `Su ${date ?? ''}`,
presets: {
[CONST.SEARCH.DATE_PRESETS.NEVER]: 'Mai',
- [CONST.SEARCH.DATE_PRESETS.LAST_MONTH]: 'Il mese scorso',
+ [CONST.SEARCH.DATE_PRESETS.LAST_MONTH]: 'Ultimo mese',
[CONST.SEARCH.DATE_PRESETS.THIS_MONTH]: 'Questo mese',
[CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: 'Da inizio anno',
+ [CONST.SEARCH.DATE_PRESETS.LAST_12_MONTHS]: 'Ultimi 12 mesi',
[CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT]: 'Ultimo estratto conto',
},
},
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index ef4ebe06..3d2218e0 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -7204,10 +7204,11 @@ ${reportName}
after: (date?: string) => `${date ?? ''} の後`,
on: (date?: string) => `${date ?? ''} に発生`,
presets: {
- [CONST.SEARCH.DATE_PRESETS.NEVER]: '決してない',
+ [CONST.SEARCH.DATE_PRESETS.NEVER]: 'しない',
[CONST.SEARCH.DATE_PRESETS.LAST_MONTH]: '先月',
[CONST.SEARCH.DATE_PRESETS.THIS_MONTH]: '今月',
- [CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: '年初来（累計）',
+ [CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: '年初来',
+ [CONST.SEARCH.DATE_PRESETS.LAST_12_MONTHS]: '過去12か月',
[CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT]: '最新明細書',
},
},
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 644cdae7..acf99ac8 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -7263,6 +7263,7 @@ Vereis onkostendetails zoals bonnen en beschrijvingen, stel limieten en standaar
[CONST.SEARCH.DATE_PRESETS.LAST_MONTH]: 'Vorige maand',
[CONST.SEARCH.DATE_PRESETS.THIS_MONTH]: 'Deze maand',
[CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: 'Jaar tot nu toe',
+ [CONST.SEARCH.DATE_PRESETS.LAST_12_MONTHS]: 'Laatste 12 maanden',
[CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT]: 'Laatste afschrift',
},
},
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 6c9af93e..37a9daaf 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -7250,8 +7250,9 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
presets: {
[CONST.SEARCH.DATE_PRESETS.NEVER]: 'Nigdy',
[CONST.SEARCH.DATE_PRESETS.LAST_MONTH]: 'W zeszłym miesiącu',
- [CONST.SEARCH.DATE_PRESETS.THIS_MONTH]: 'Ten miesiąc',
+ [CONST.SEARCH.DATE_PRESETS.THIS_MONTH]: 'W tym miesiącu',
[CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: 'Od początku roku',
+ [CONST.SEARCH.DATE_PRESETS.LAST_12_MONTHS]: 'Ostatnie 12 miesięcy',
[CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT]: 'Ostatnie zestawienie',
},
},
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 63e7e4a1..b7a7d319 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -7254,7 +7254,8 @@ Exija dados de despesas como recibos e descrições, defina limites e padrões e
[CONST.SEARCH.DATE_PRESETS.NEVER]: 'Nunca',
[CONST.SEARCH.DATE_PRESETS.LAST_MONTH]: 'Mês passado',
[CONST.SEARCH.DATE_PRESETS.THIS_MONTH]: 'Este mês',
- [CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: 'Ano até a data',
+ [CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: 'Ano até agora',
+ [CONST.SEARCH.DATE_PRESETS.LAST_12_MONTHS]: 'Últimos 12 meses',
[CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT]: 'Último extrato',
},
},
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 73cbf9b9..cbddfd4e 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7085,7 +7085,8 @@ ${reportName}
[CONST.SEARCH.DATE_PRESETS.NEVER]: '从不',
[CONST.SEARCH.DATE_PRESETS.LAST_MONTH]: '上个月',
[CONST.SEARCH.DATE_PRESETS.THIS_MONTH]: '本月',
- [CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: '本年度至今',
+ [CONST.SEARCH.DATE_PRESETS.YEAR_TO_DATE]: '年初至今',
+ [CONST.SEARCH.DATE_PRESETS.LAST_12_MONTHS]: '过去 12 个月',
[CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT]: '上一期对账单',
},
},
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
requested review from
JmillsExpensify
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds a new date preset for filtering data in Search. Updates the Spend Over Time insight to use it.
Fixed Issues
$ #85346
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Nagranie.z.ekranu.2026-03-20.o.10.34.03.mov
Android: mWeb Chrome
Uploading Nagranie z ekranu 2026-03-20 o 10.40.27.mov…
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2026-03-20.at.10.45.40.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2026-03-20.at.10.47.54.mp4
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-03-20.o.10.15.50.mov