Add trackExpensesWithConcierge onboarding RHP variant#85762
Draft
Add trackExpensesWithConcierge onboarding RHP variant#85762
Conversation
Track workspace admins land on Home page with Concierge side panel (desktop) or Concierge DM chat (mobile) for onboarding tasks. Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
Contributor
Author
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
Contributor
Author
|
The failing check is unrelated to this PR. Analysis: The only failing check is
This PR only modifies onboarding RHP variant files ( Evidence:
Retrying the CI run should resolve this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds the
trackExpensesWithConciergeonboarding RHP variant for Track workspace admins. When the backend sets this variant, Track-intent admins (newDotTrackWorkspace) will:Unlike the existing RHP variants (which require micro company size), this variant applies regardless of company size.
Note: Task
parentReportIDfor Track workspace users already points to the Concierge DM (existing behavior inisPostingTasksInAdminsRoom), so onboarding tasks already appear in the Concierge chat — no change needed there.Fixed Issues
$ #85226
Tests
ONBOARDING_RHP_VARIANTNVP totrackExpensesWithConciergefor a new Track workspace adminnewDotTrackWorkspacechoicerhpConciergeDm,rhpAdminsRoom,rhpHomePage) still work as before (still gated by micro company size)controlvariant still navigates to last accessed report / Home as beforeOffline tests
N/A — This change only affects post-onboarding navigation, which happens after an API response.
QA Steps
trackExpensesWithConciergeas the RHP variantPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari