[CP Staging] prevent deep link from LHN action badge#85786
[CP Staging] prevent deep link from LHN action badge#85786cristipaval merged 1 commit intoExpensify:mainfrom
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mountiny
left a comment
There was a problem hiding this comment.
Just waiting for a quick retest from @hoangzinh
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-03-19.at.19.59.04.moviOS: mWeb SafariScreen.Recording.2026-03-19.at.19.50.55.movMacOS: Chrome / SafariScreen.Recording.2026-03-19.at.19.44.21.mov |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a965aa8a7b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return; | ||
| } | ||
| Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(option.reportID, isProduction ? undefined : option.actionTargetReportActionID)); | ||
| Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(option.reportID)); |
There was a problem hiding this comment.
Preserve reportActionID when opening badge-marked chats
In non-production builds the LHN still shows Approve/Pay/Submit/Fix badges (src/components/LHNOptionsList/OptionRowLHN.tsx:164), but this change always drops actionTargetReportActionID from the route. ReportScreen feeds that param into usePaginatedReportActions(reportID, reportActionID), and the hook only loads the chain containing the linked action; without it, it falls back to the newest page of actions (src/hooks/usePaginatedReportActions.ts:17-20,47-76). So when the actionable preview or failing action is older than the latest chat messages, clicking the badge-marked row now opens the room without the target action loaded, which makes the badge unable to take QA/internal users to the item it refers to.
Useful? React with 👍 / 👎.
|
I have an issue with android simulator but I believe this PR will work in all platforms |
[CP Staging] prevent deep link from LHN action badge (cherry picked from commit b0e7388) (cherry-picked to staging by mountiny)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.40-8 🚀
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.40-10 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.41-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀
|
Explanation of Change
Preconditions:
Fixed Issues
$ #85744
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari