Add selection mode Submit/Approve/Pay actions for mobile layout.#85796
Draft
Krishna2323 wants to merge 3 commits intoExpensify:mainfrom
Draft
Add selection mode Submit/Approve/Pay actions for mobile layout.#85796Krishna2323 wants to merge 3 commits intoExpensify:mainfrom
Krishna2323 wants to merge 3 commits intoExpensify:mainfrom
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #72502
PROPOSAL:
Tests
Same as QA Steps
Verify that no errors appear in the JS console
Offline tests
QA Steps
Submit action via selection mode (Mobile)
MoneyRequestReportActionsList)Approve action via selection mode (Mobile)
Pay action via selection mode (Mobile)
Approve with delegate restriction (Mobile)
Approve with held expenses (Mobile)
Pay as business (Mobile)
Pay with delegate restriction (Mobile)
Partial selection — no report-level actions (Mobile)
ButtonWithDropdownMenu(not the KYC dropdown)KYC dropdown vs plain dropdown rendering (Mobile-specific)
MoneyReportHeaderKYCDropdown(KYC-integrated)ButtonWithDropdownMenuNon-regression: header buttons still work (Mobile)
Non-regression: header Approve (Mobile)
Non-regression: header Pay (Mobile)
Offline behavior (Mobile)
isOffline && !canAllowSettlement(KYCWall guards payment offline)Selection mode exit on last transaction delete (Mobile-specific)
Locked account guard (Mobile)
Unvalidated account guard (Mobile)
Invoice payment via selection mode (Mobile)
payInvoiceis called (notpayMoneyRequest)Submit blocked by policy rules (Mobile)
preventSelfApprovalis enabled and the submitter is the next approverPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari