Skip to content

Add selection mode Submit/Approve/Pay actions for mobile layout.#85796

Draft
Krishna2323 wants to merge 3 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/72502-3
Draft

Add selection mode Submit/Approve/Pay actions for mobile layout.#85796
Krishna2323 wants to merge 3 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/72502-3

Conversation

@Krishna2323
Copy link
Contributor

@Krishna2323 Krishna2323 commented Mar 19, 2026

Explanation of Change

Fixed Issues

$ #72502
PROPOSAL:

Tests

  • Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

  • Same as QA Steps

QA Steps

Submit action via selection mode (Mobile)

  1. Open the app in a narrow/mobile viewport (or on a mobile device)
  2. Open an expense report where the primary action is "Submit"
  3. Long-press an expense to enter selection mode
  4. Select all expenses using the checkboxes
  5. Verify the "X selected" dropdown appears at the top of the expense list (inside MoneyRequestReportActionsList)
  6. Open the dropdown — verify "Submit" appears at the top
  7. Click "Submit"
  8. Verify the report is submitted, selections are cleared, and selection mode exits

Approve action via selection mode (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Open a submitted expense report as an approver
  3. Long-press an expense to enter selection mode, then select all expenses
  4. Open the "X selected" dropdown — verify "Approve" appears at the top
  5. Click "Approve"
  6. Verify the report is approved and selections are cleared

Pay action via selection mode (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Open an approved expense report ready to be paid
  3. Long-press an expense to enter selection mode, then select all expenses
  4. Verify the "X selected" dropdown renders as a KYC-integrated dropdown (not a plain button)
  5. Open the dropdown — verify "Pay $X.XX" appears with a right arrow and payment method submenu items
  6. Click "Pay $X.XX" — verify a submenu opens with payment methods
  7. Select "Pay elsewhere"
  8. Verify payment processes, selections are cleared, and "You're all set!" RHP does not open
  9. Verify Pay is no longer shown in the dropdown

Approve with delegate restriction (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Log in as a delegate with restricted access
  3. Open a submitted expense report
  4. Long-press to enter selection mode, select all expenses
  5. Open the "X selected" dropdown and click "Approve"
  6. Verify the "no access" modal appears
  7. Dismiss the modal
  8. Verify selections are still active (not cleared)

Approve with held expenses (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Open a submitted expense report where some expenses are on hold
  3. Long-press to enter selection mode, select all expenses
  4. Open the "X selected" dropdown and click "Approve"
  5. Verify the hold menu appears
  6. Verify selections are cleared after confirming

Pay as business (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Open an approved expense report, long-press to enter selection mode, select all expenses
  3. Open Pay submenu, select "Pay as business" (if available)
  4. Verify payment processes without the "You're all set!" RHP opening
  5. Verify selections are cleared

Pay with delegate restriction (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Log in as a delegate with restricted access
  3. Open an approved expense report, long-press to enter selection mode, select all expenses
  4. Open Pay submenu, select a payment method
  5. Verify the "no access" modal appears
  6. Verify selections are not cleared

Partial selection — no report-level actions (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Open an expense report with 3+ expenses
  3. Long-press to enter selection mode, select only some (not all) expenses
  4. Open the "X selected" dropdown
  5. Verify Submit/Approve/Pay do not appear — only transaction-level actions
  6. Verify the dropdown renders as a plain ButtonWithDropdownMenu (not the KYC dropdown)

KYC dropdown vs plain dropdown rendering (Mobile-specific)

  1. Open the app in a narrow/mobile viewport
  2. Open an approved expense report (Pay action available)
  3. Long-press to enter selection mode, select all expenses
  4. Verify the dropdown renders as MoneyReportHeaderKYCDropdown (KYC-integrated)
  5. Deselect one expense so not all are selected
  6. Verify the dropdown switches back to a plain ButtonWithDropdownMenu
  7. Re-select all expenses — verify it switches back to the KYC dropdown

Non-regression: header buttons still work (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Open a draft expense report, do not enter selection mode
  3. Tap "Submit" in the header
  4. Verify the report is submitted normally with animation

Non-regression: header Approve (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Open a submitted report as approver, do not enter selection mode
  3. Tap "Approve" in the header
  4. Verify approval completes normally with animation

Non-regression: header Pay (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Open an approved report, do not enter selection mode
  3. Tap "Pay" in the header, select "Pay elsewhere"
  4. Verify payment completes normally with animation

Offline behavior (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Go offline
  3. Open an expense report, long-press to enter selection mode, select all expenses
  4. Verify Submit/Approve appear and can be clicked
  5. Verify Pay does not appear when isOffline && !canAllowSettlement (KYCWall guards payment offline)

Selection mode exit on last transaction delete (Mobile-specific)

  1. Open the app in a narrow/mobile viewport
  2. Open an expense report with 2 expenses
  3. Long-press to enter selection mode, select both expenses
  4. Delete one expense (if supported from selection mode)
  5. Verify selection mode adjusts correctly (count updates, or exits if <1 remain)

Locked account guard (Mobile)

  1. Open the app in a narrow/mobile viewport with a locked account
  2. Open an approved expense report, enter selection mode, select all
  3. Open Pay submenu, select a payment method
  4. Verify the locked account modal appears (not the payment flow)
  5. Verify selections are not cleared

Unvalidated account guard (Mobile)

  1. Open the app in a narrow/mobile viewport with an unvalidated account
  2. Open an approved expense report, enter selection mode, select all
  3. Open Pay submenu, select a payment method
  4. Verify the user is redirected to validate their account
  5. Verify selections are not cleared

Invoice payment via selection mode (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Open an invoice report ready to be paid
  3. Enter selection mode, select all expenses
  4. Open the "X selected" dropdown, select a payment method
  5. Verify payInvoice is called (not payMoneyRequest)
  6. Verify selections are cleared

Submit blocked by policy rules (Mobile)

  1. Open the app in a narrow/mobile viewport
  2. Open an expense report where preventSelfApproval is enabled and the submitter is the next approver
  3. Enter selection mode, select all expenses
  4. Open the "X selected" dropdown
  5. Verify Submit does not appear in the dropdown
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...equestReportView/MoneyRequestReportActionsList.tsx 57.73% <63.63%> (+0.24%) ⬆️
src/hooks/useSelectionModeReportActions.ts 49.06% <49.06%> (ø)
... and 88 files with indirect coverage changes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant