[ECUK In-App 3DS][LOW] Call getActionableCard3DSTransactionApprovalMessage for thread titles, sidebar message previews, and message copy-paste#86240
Conversation
…, sidebar message previews, and message copy-paste
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hm, I don't know why pullerbear assigned two C+'s but this needs to be tested by people who can test 3DS, so I'm keeping it within the ECUK project |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-03-24.at.5.35.29.PM.mov |
rafecolton
left a comment
There was a problem hiding this comment.
Simple change, works great. Thanks!
|
🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rafecolton in version: 9.3.44-0 🚀
Bundle Size Analysis (Sentry): |
|
@chuckdries @rafecolton only piece that doesn't work is pasting the copied message. It's pasting in English even when my app is in French. 2026-03-25_13-06-34.mp4 |
|
Checking off bcause this does not feel like a blocker |
|
🚀 Deployed to staging by https://github.com/rafecolton in version: 9.3.47-0 🚀
Bundle Size Analysis (Sentry): |
|
Hm, that's really weird, I wasn't able to reproduce the copy/paste issue. Both in my original test and just now on main, I tried copying/pasting from both a message I threaded on and one I didn't, and both pasted in the translated language 🤔 |
|
Does it matter that I changed the language after the challenge message was sent? The QA steps said to do that, so that's what I did, but maybe that impacts the copying/pasting? |
|
I'm not sure, I think it should work either way. I did it the same way you did. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.3.48-2 🚀
|
Explanation of Change
I missed a few spots when I originally added
getActionableCard3DSTransactionApprovalMessage, which is the function responsible for localizing the concierge message that users receive when they get a 3DS challenge. The following places were falling back to the server-provided english strings:Note that I don't actually expect users to do 3 ever, but might as well be thorough
Fixed Issues
$ #86008
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests - assign to @joekaufmanexpensify for QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari