Strip @expensify.sms suffix from category/tag approver display by MelvinBot · Pull Request #86303 · Expensify/App

MelvinBot · 2026-03-25T07:37:51Z

Explanation of Change

When a phone number user is set as a category or tag approver, the approver name displays the raw @expensify.sms suffix (e.g., +15857527441@expensify.sms). This happens because CategorySettingsPage, TagSettingsPage, and WorkspaceMembersSelectionList use displayName directly without stripping the SMS domain.

This PR wraps the approver display text with formatPhoneNumber() (from useLocalize) to strip the @expensify.sms suffix and format the phone number in a locale-aware way. This is consistent with how WorkspaceCategoriesPage and WorkspaceTagsPage already handle the same approver display names.

Fixed Issues

$ #86243
PROPOSAL: #86243 (comment)

Tests

Add a phone number as a workspace member (e.g., a valid phone number)
Navigate to Workspace > Categories (Control workspace with rules enabled)
Select any category and choose Approver
Select the phone number user
Verify the approver is displayed as a clean phone number (no @expensify.sms suffix)
Repeat for Workspace > Tags: select a tag, choose Approver, select the phone number user
Verify the tag approver is also displayed as a clean phone number

Verify that no errors appear in the JS console

Offline tests

N/A — this is a display-only change that formats data already available locally.

QA Steps

Add a phone number as a workspace member
Navigate to Workspace > Categories (Control workspace with rules enabled)
Select any category, choose Approver, and select the phone number user
Verify the approver shows a clean phone number without @expensify.sms
Repeat for Workspace > Tags: select a tag, choose Approver, select the phone number user
Verify the tag approver also shows a clean phone number without @expensify.sms
Also verify that in the approver selection list, phone number users show formatted numbers

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…tings Apply formatPhoneNumber to approver display names in CategorySettingsPage, TagSettingsPage, and WorkspaceMembersSelectionList so phone number users show clean formatted numbers instead of raw SMS logins. Co-authored-by: huult <huult@users.noreply.github.com>

MelvinBot · 2026-03-25T07:38:34Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixCategoryApproverSmsDisplay
git checkout -b claude-fixCategoryApproverSmsDisplay upstream/claude-fixCategoryApproverSmsDisplay
git push -u origin claude-fixCategoryApproverSmsDisplay

Then you can close this PR and open a new one from your fork.

codecov · 2026-03-25T07:46:17Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/workspace/tags/TagSettingsPage.tsx	`0.00% <0.00%> (ø)`
...ages/workspace/categories/CategorySettingsPage.tsx	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

huult · 2026-03-25T08:16:52Z

@MelvinBot I didn’t see the issue in WorkspaceMembersSelectionList, so could you revert the changes in WorkspaceMembersSelectionList?

Co-authored-by: huult <huult@users.noreply.github.com>

MelvinBot · 2026-03-25T08:18:43Z

Reverted the changes in WorkspaceMembersSelectionList.tsx as requested — the formatPhoneNumber wrapping has been removed from that file. The fix in CategorySettingsPage and TagSettingsPage remains intact.

huult · 2026-03-25T08:20:21Z

@MelvinBot Please mark it as "Ready for review"

melvin-bot · 2026-03-25T08:22:12Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-03-25T08:22:13Z

PR has been marked as Ready for review as requested.

huult · 2026-03-25T08:38:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-25.at.15.29.36.mp4

Android: mWeb Chrome

Screen.Recording.2026-03-25.at.15.30.46.mp4

iOS: HybridApp

Screen.Recording.2026-03-25.at.15.34.32.mp4

iOS: mWeb Safari

Screen.Recording.2026-03-25.at.15.35.15.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-03-25.at.15.24.46.mp4

huult

LGTM!

melvin-bot · 2026-03-25T08:40:02Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #86243 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

inimaga

lgtm

github-actions · 2026-03-25T10:04:51Z

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-25T10:09:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86303.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-73fc4dd-15c7bec-c0f3778a6e11091a6078c0520850e6c1cc57d644/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-73fc4dd-15c7bec-a67cd263d6411fd7f41c8501ffed5f096f7bfffb/index.html

Web 🕸️
https://86303.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-25T10:11:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-25T16:41:24Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.44-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-25T18:53:39Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.47-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-26T14:19:00Z

🚀 Deployed to production by https://github.com/grgia in version: 9.3.48-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned huult Mar 25, 2026

MelvinBot requested a review from a team March 25, 2026 07:37

MelvinBot mentioned this pull request Mar 25, 2026

[Due for payment 2026-04-02] [$250] Category approver shows “@expensify.sms” suffix for phone number users #86243

Open

7 tasks

Revert WorkspaceMembersSelectionList changes per reviewer feedback

cced71f

Co-authored-by: huult <huult@users.noreply.github.com>

MelvinBot marked this pull request as ready for review March 25, 2026 08:22

MelvinBot requested a review from a team as a code owner March 25, 2026 08:22

melvin-bot bot requested a review from huult March 25, 2026 08:22

melvin-bot bot removed the request for review from a team March 25, 2026 08:22

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 25, 2026 08:22

huult approved these changes Mar 25, 2026

View reviewed changes

melvin-bot bot requested a review from inimaga March 25, 2026 08:40

inimaga approved these changes Mar 25, 2026

View reviewed changes

inimaga merged commit 73fc4dd into main Mar 25, 2026
40 checks passed

inimaga deleted the claude-fixCategoryApproverSmsDisplay branch March 25, 2026 10:03

OSBotify mentioned this pull request Mar 25, 2026

Deploy Checklist: New Expensify 2026-03-25 #86329

Closed

71 tasks

Conversation

MelvinBot commented Mar 25, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 25, 2026

Uh oh!

codecov bot commented Mar 25, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Mar 25, 2026

Uh oh!

MelvinBot commented Mar 25, 2026

Uh oh!

huult commented Mar 25, 2026

Uh oh!

melvin-bot bot commented Mar 25, 2026

Uh oh!

MelvinBot commented Mar 25, 2026

Uh oh!

huult commented Mar 25, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 25, 2026

Uh oh!

inimaga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

OSBotify commented Mar 25, 2026

Uh oh!

OSBotify commented Mar 25, 2026

Uh oh!

OSBotify commented Mar 25, 2026

Uh oh!

OSBotify commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Mar 25, 2026 •

edited by github-actions bot

Loading