[No QA] Fix typecheck: use reportAttributes in SearchPageTabSelector#86341
[No QA] Fix typecheck: use reportAttributes in SearchPageTabSelector#86341puneetlath merged 1 commit intomainfrom
Conversation
…rchPageTabSelector The buildUserReadableQueryString function's type was updated in PR #85975 to accept reportAttributes instead of conciergeReportID. SearchPageTabSelector was introduced in PR #84036 using the old property name, causing a type error on main. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
|
@MelvinBot mark as ready for review |
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Done! PR has been marked as ready for review. ✅ |
|
@MelvinBot add |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.49-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.3.49-2 🚀
|
Explanation of Change
PR #85975 (merged 2026-03-20) refactored
buildUserReadableQueryStringinSearchQueryUtils.tsto acceptreportAttributesinstead ofconciergeReportID. PR #84036 (merged 2026-03-25) introducedSearchPageTabSelector.tsxwhich still used the oldconciergeReportIDproperty, causing the typecheck failure on main.This PR updates
SearchPageTabSelector.tsxto useuseReportAttributes()and passreportAttributestobuildUserReadableQueryString(), matching the pattern used by all other callers (SavedSearchList.tsx,useSearchTypeMenu.tsx,SearchPageHeaderInput.tsx,SearchAutocompleteList.tsx).Fixed Issues
$ #86330
Tests
Offline tests
N/A - This is a type-only fix that doesn't change runtime behavior.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - Type-only fix, no visual changes
Android: mWeb Chrome
N/A - Type-only fix, no visual changes
iOS: Native
N/A - Type-only fix, no visual changes
iOS: mWeb Safari
N/A - Type-only fix, no visual changes
MacOS: Chrome / Safari
N/A - Type-only fix, no visual changes