[CP staging] fix: arrow button on report carousel is larger than the left arrow by daledah · Pull Request #86625 · Expensify/App

daledah · 2026-03-30T03:33:25Z

Explanation of Change

Fixed Issues

$ #76266
#86546
PROPOSAL:

Tests

Go to staging.new.expensify.com
Go to workspace chat.
Create two reports.
Go to Reports > Reports.
Open any report.
Verify that: The left and right arrow button on report carousel will have the same size.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-03-30T03:35:41Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2026-03-30T03:45:25Z

It seems the assignment flow failed. @dominictb please review this PR

codecov · 2026-03-30T03:45:28Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/PrevNextButtons.tsx	`100.00% <ø> (ø)`
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`61.29% <ø> (ø)`
... and 23 files with indirect coverage changes

dominictb · 2026-03-30T04:12:32Z

@daledah Same issue in MoneyRequestPreviewContent:

dominictb · 2026-03-30T04:13:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

daledah · 2026-03-30T06:49:40Z

@daledah Same issue in MoneyRequestPreviewContent:

i updated

dominictb

🎀

dominictb · 2026-03-30T09:30:09Z

@grgia Good to merge

github-actions · 2026-03-30T16:13:01Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-30T16:18:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86625.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1fec499-04b7b10-42b0d6122d78c4b55b2dc52c0031e54f3efcce18/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1fec499-04b7b10-e1e5ef8902ff36f58bd5edf17d05e2151bb54dc0/index.html

Web 🕸️
https://86625.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-30T16:20:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP staging] fix: arrow button on report carousel is larger than the left arrow (cherry picked from commit 1fec499) (cherry-picked to staging by jasperhuangg)

OSBotify · 2026-03-30T19:23:19Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.50-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-03-30T19:24:50Z

No help site changes are required for this PR.

This is a purely visual bug fix that adjusts icon sizing props on the back arrow buttons in PrevNextButtons.tsx and MoneyRequestReportPreviewContent.tsx to make the left and right arrow buttons the same size in the report carousel.

No features, settings, labels, navigation paths, or user-facing behavior changed — only the visual consistency of arrow button sizes was corrected. The help site documentation under docs/articles does not need any updates.

IuliiaHerets · 2026-03-30T20:09:57Z

@daledah CP was passed by QA team on Web, Android and iOS

cc @grgia @JS00001 @joekaufmanexpensify @thesahindia

1774900992533.86625-iOS.mp4

1774900879476.Screenrecorder-2026-03-30-22-58-25-863.mp4

1774900660240.86625-Web.mp4

OSBotify · 2026-03-31T20:05:23Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.51-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-03-31T20:07:03Z

Confirmed: No help site changes are required for this PR.

I've re-reviewed the diff after reading the authoring guidelines. This PR changes only icon sizing props (small/isButtonIcon → explicit width/height) on the BackArrow icon in:

src/components/PrevNextButtons.tsx
src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

This is a purely visual bug fix to make the left and right arrow buttons in the report carousel the same size. No features, settings, labels, tab names, navigation paths, or user-facing behavior changed — only icon dimension consistency was corrected.

The help site documentation under docs/articles does not reference arrow button sizing or carousel navigation controls, so no updates are needed.

OSBotify · 2026-03-31T21:53:00Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-04-02T19:56:27Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.51-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

shawnborton · 2026-04-07T15:55:33Z

Hmm what I am not following here - I thought we overwrote all of the old arrows with the new, slimmer arrows? So why would this bug have existed in the first place? We only should have one type of arrow to show.

shawnborton · 2026-04-07T15:57:13Z

src/components/PrevNextButtons.tsx

                    <Icon
                        src={icons.BackArrow}
-                        small
+                        width={variables.iconSizeNormal}


What size are the buttons? When we use buttons that are small (28x28) we usually want icons that are 12x12:

I think we need to follow up and fix these. cc @daledah @Expensify/design

Sure @shawnborton. It'll be handled in this PR

fix: arrow button on report carousel is larger than the left arrow

bdc91c6

melvin-bot bot assigned daledah Mar 30, 2026

daledah marked this pull request as ready for review March 30, 2026 03:35

daledah requested review from a team as code owners March 30, 2026 03:35

melvin-bot bot requested a review from thesahindia March 30, 2026 03:35

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 30, 2026 03:35

fix back arrow style in money request preview content

22f3fef

grgia approved these changes Mar 30, 2026

View reviewed changes

grgia changed the title ~~fix: arrow button on report carousel is larger than the left arrow~~ [CP staging[ fix: arrow button on report carousel is larger than the left arrow Mar 30, 2026

grgia changed the title ~~[CP staging[ fix: arrow button on report carousel is larger than the left arrow~~ [CP staging] fix: arrow button on report carousel is larger than the left arrow Mar 30, 2026

dominictb approved these changes Mar 30, 2026

View reviewed changes

JS00001 approved these changes Mar 30, 2026

View reviewed changes

JS00001 merged commit 1fec499 into Expensify:main Mar 30, 2026
37 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 30, 2026

OSBotify mentioned this pull request Mar 30, 2026

Deploy Checklist: New Expensify 2026-03-27 #86530

Closed

86 tasks

melvin-bot bot mentioned this pull request Mar 31, 2026

[Due for payment 2026-04-07] [$500] Change option row and push inputs chevrons to new look #76266

Open

daledah mentioned this pull request Apr 7, 2026

Change option row and push inputs chevrons to new look #76292

Merged

53 tasks

shawnborton reviewed Apr 7, 2026

View reviewed changes

daledah mentioned this pull request Apr 8, 2026

fix: RBR is not close to chevron #86646

Open

52 tasks

Conversation

daledah commented Mar 30, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 30, 2026

Uh oh!

daledah commented Mar 30, 2026

Uh oh!

codecov bot commented Mar 30, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dominictb commented Mar 30, 2026

Uh oh!

dominictb commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

daledah commented Mar 30, 2026

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

dominictb commented Mar 30, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

OSBotify commented Mar 30, 2026

Uh oh!

OSBotify commented Mar 30, 2026

Uh oh!

MelvinBot commented Mar 30, 2026

Uh oh!

IuliiaHerets commented Mar 30, 2026

Uh oh!

OSBotify commented Mar 31, 2026

Uh oh!

MelvinBot commented Mar 31, 2026

Uh oh!

OSBotify commented Mar 31, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

shawnborton commented Apr 7, 2026

Uh oh!

shawnborton Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

daledah Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

shawnborton Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov bot commented Mar 30, 2026 •

edited by github-actions bot

Loading

dominictb commented Mar 30, 2026 •

edited

Loading