Skip to content

Fix Cmd+K search missing workspace members and blocking selection during loading#87367

Merged
blimpich merged 1 commit into
mainfrom
claude-cmdKSearchMissesWorkspaceMembers
Apr 10, 2026
Merged

Fix Cmd+K search missing workspace members and blocking selection during loading#87367
blimpich merged 1 commit into
mainfrom
claude-cmdKSearchMissesWorkspaceMembers

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Bug 1 — Cmd+K misses workspace members: getValidOptions calculates personalDetails slots as maxElements - reports - workspaceChats, which drops to 0 when reports consume the full budget (50). Workspace members without an existing DM report only exist in the personalDetails list and become invisible. This fix guarantees a minimum of 5 personalDetails slots regardless of how many reports match, so workspace members always have a chance to appear.

Bug 2 — Cannot select results during loading: When areOptionsInitialized is false and the user has typed a search query, SearchAutocompleteList silently omits the recent chats section — even if results are already available from server search. This fix renders available results immediately when a search query is active, so users can select them without waiting for full initialization.

Fixed Issues

$ #87035
PROPOSAL: #87035 (comment)

Tests

  1. Open Cmd+K (or Ctrl+K on non-Mac)
  2. Search for a workspace member you haven't recently chatted with
  3. Verify they appear immediately in results (from local personalDetails) without waiting for server search
  4. Verify the result is immediately selectable (not blocked by a loading skeleton)
  • Verify that no errors appear in the JS console

Offline tests

  1. Disconnect from the network
  2. Open Cmd+K and search for a workspace member
  3. Verify that workspace members from personalDetails still appear in results (since they're cached locally)

QA Steps

  1. Open Cmd+K search
  2. Search for a workspace member you haven't recently chatted with by name
  3. Verify the member appears immediately in the results list
  4. Verify the result is selectable right away without waiting for a spinner to finish
  5. Verify that normal search still works as expected for recent chats, workspace chats, etc.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot @ZhenjaHorbach
Fix Cmd+K search missing workspace members and blocking selection dur…
cf87744 
…ing loading

Bug 1: Guarantee a minimum of 5 personalDetails slots in getValidOptions
so workspace members without an existing DM report remain visible even
when report results consume most of the selection list budget.

Bug 2: When options aren't fully initialized but a search query has
available results, render them immediately instead of silently omitting
the section, so users can select results without waiting for full
initialization.

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team April 8, 2026 11:50
@MelvinBot MelvinBot mentioned this pull request Apr 8, 2026
Closed
@ZhenjaHorbach

ZhenjaHorbach commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot
Open this PR

@MelvinBot

MelvinBot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

This PR is already open. Is there something else you'd like me to do with it?

@ZhenjaHorbach

ZhenjaHorbach commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot
This PR is in draft
Open it

@MelvinBot MelvinBot marked this pull request as ready for review April 10, 2026 07:48
@MelvinBot MelvinBot requested a review from a team as a code owner April 10, 2026 07:48
@melvin-bot melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team April 10, 2026 07:48
@melvin-bot

melvin-bot Bot commented Apr 10, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from trjExpensify and removed request for a team April 10, 2026 07:48
@MelvinBot

MelvinBot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Done — this PR is now marked as ready for review. ✅

@trjExpensify

trjExpensify commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

@trjExpensify trjExpensify removed their request for review April 10, 2026 11:08
@ZhenjaHorbach

ZhenjaHorbach commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-04-10.18.03.17.mov

@ZhenjaHorbach

ZhenjaHorbach commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

LGTM!

@melvin-bot

melvin-bot Bot commented Apr 10, 2026

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #87035 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@melvin-bot melvin-bot Bot requested a review from blimpich April 10, 2026 16:10
@blimpich blimpich merged commit b692949 into main Apr 10, 2026
44 checks passed
@blimpich blimpich deleted the claude-cmdKSearchMissesWorkspaceMembers branch April 10, 2026 16:15
@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87367.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b692949-74dae60-dcbf40cb32b716e55972a9f2efaec83d0b4919c7/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b692949-74dae60-99de1c88481107ad850719baf73f0e6a853e698e/index.html
Android iOS
Web 🕸️
https://87367.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify

OSBotify commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Apr 13, 2026
Closed
89 tasks
@OSBotify

OSBotify commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.59-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

Bundle Size Analysis (Sentry):

@MelvinBot

MelvinBot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

No help site changes are required for this PR.

The changes are purely bug fixes to existing Cmd+K search behavior:

  1. Personal details slot allocation (OptionsListUtils/index.ts) — guarantees a minimum of 5 personalDetails slots so workspace members without an existing DM report remain visible.
  2. Result rendering during initialization (SearchAutocompleteList.tsx) — renders available results immediately when a search query is active, even if options aren't fully initialized.

Neither change introduces new features, modifies UI labels/settings, or alters any documented user-facing workflow. The existing help articles that mention search reference it only incidentally (e.g., searching for reports, invoices) and are unaffected by these internal fixes.

@MelvinBot MelvinBot mentioned this pull request Apr 14, 2026
Closed
@OSBotify

OSBotify commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blimpich blimpich blimpich approved these changes

+1 more reviewer

@ZhenjaHorbach ZhenjaHorbach ZhenjaHorbach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ZhenjaHorbach ZhenjaHorbach

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MelvinBot @ZhenjaHorbach @trjExpensify @OSBotify @blimpich