Reset footerSize when ListFooterComponent is removed in draggable-flatlist patch by MelvinBot · Pull Request #87463 · Expensify/App

MelvinBot · 2026-04-09T08:11:26Z

Explanation of Change

When rotating from portrait to landscape on the distance request map, the ListFooterComponent (the map) is removed from the DraggableList and moved to a side panel. However, the footerSize shared value in the react-native-draggable-flatlist patch retains its stale value (~300px). This causes maxTranslatePositive to become a large negative number, clamping the dragged waypoint cell off-screen during reorder.

This PR updates the existing react-native-draggable-flatlist patch to reset footerSize.value to 0 when ListFooterComponent is removed (falsy), ensuring the drag constraint calculation uses the correct footer size.

Fixed Issues

$ #87357
PROPOSAL: #87357 (comment)

Tests

Launch the app and go to a workspace chat
Tap + > Track distance > Map
Enter 3 waypoints
Rotate the device to landscape
Long-press on the 3rd waypoint and try to reorder it
Verify the waypoint remains visible while dragging

Verify that no errors appear in the JS console

Offline tests

N/A — this is a UI rendering fix for drag-and-drop behavior that does not involve network requests.

QA Steps

Open the app on an iOS or Android device in portrait mode
Go to a workspace chat
Tap + > Track distance > Map
Enter 3 waypoints
Rotate the device to landscape
Long-press on the 3rd waypoint and drag to reorder
Verify the dragged waypoint is visible during the reorder gesture
Rotate back to portrait and verify reordering still works correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…tlist patch When rotating from portrait to landscape, ListFooterComponent becomes undefined but footerSize retains its stale value (~300px). This causes maxTranslatePositive to become a large negative number, clamping the dragged cell off-screen. Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>

Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>

MelvinBot · 2026-04-09T08:19:26Z

Fixed the failing checks: the patch file react-native-draggable-flatlist+4.0.3+001+listfooter-constraint.patch had an incorrect hunk header line count. The @@ -357,6 +366,20 @@ header declared 20 patched lines but the hunk actually contains 21 (6 context + 15 insertions). Updated to +366,21.

GCyganek · 2026-04-09T08:28:15Z

I tested these changes locally and they seem be working fine:

Screen.Recording.2026-04-09.at.10.24.34.mov

Screen.Recording.2026-04-09.at.10.26.27.mov

MelvinBot · 2026-04-09T08:32:09Z

All checks are passing now — no failures found. The checks may have been pending/in-progress when this was reported.

rushatgabhane · 2026-04-09T08:42:41Z

@MelvinBot mark ready for review

MelvinBot · 2026-04-09T08:44:41Z

✅ PR marked as ready for review per request from rushatgabhane.

melvin-bot · 2026-04-09T08:44:42Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

truph01 · 2026-04-13T08:36:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-13.at.15.32.12.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-04-13T11:12:42Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-13T11:17:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87463.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f315c87-08ff3fc-04451a178139ff3470d2e24b3c6115cdb2a6aebe/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f315c87-08ff3fc-7d1a95eb7751d7cae4988e2d4baeac7a1bbd45f3/index.html

Web 🕸️
https://87463.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-13T11:21:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-13T20:33:53Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.59-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android

OSBotify · 2026-04-16T03:30:32Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned mjasikowski Apr 9, 2026

MelvinBot requested a review from a team April 9, 2026 08:11

MelvinBot mentioned this pull request Apr 9, 2026

[Due for payment 2026-04-23] Waypoint is not visible when trying to reorder after switching from portrait to landscape #87357

Closed

7 tasks

Fix patch file hunk header line count (20 → 21)

a0f9d64

Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>

MelvinBot marked this pull request as ready for review April 9, 2026 08:44

melvin-bot Bot requested a review from truph01 April 9, 2026 08:44

melvin-bot Bot removed the request for review from a team April 9, 2026 08:44

MelvinBot mentioned this pull request Apr 9, 2026

[$250] Other A11y: Global: The app cannot be used in a landscape mode #77280

Open

truph01 approved these changes Apr 13, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski April 13, 2026 08:36

mjasikowski approved these changes Apr 13, 2026

View reviewed changes

mjasikowski merged commit f315c87 into main Apr 13, 2026
32 checks passed

mjasikowski deleted the claude-fixDraggableListFooterSizeReset branch April 13, 2026 11:09

OSBotify mentioned this pull request Apr 13, 2026

Deploy Checklist: New Expensify 2026-04-13 #87792

Closed

89 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reset footerSize when ListFooterComponent is removed in draggable-flatlist patch#87463

Reset footerSize when ListFooterComponent is removed in draggable-flatlist patch#87463
mjasikowski merged 2 commits into
mainfrom
claude-fixDraggableListFooterSizeReset

MelvinBot commented Apr 9, 2026

Uh oh!

MelvinBot commented Apr 9, 2026

Uh oh!

GCyganek commented Apr 9, 2026

Uh oh!

MelvinBot commented Apr 9, 2026

Uh oh!

rushatgabhane commented Apr 9, 2026

Uh oh!

MelvinBot commented Apr 9, 2026

Uh oh!

melvin-bot Bot commented Apr 9, 2026

Uh oh!

truph01 commented Apr 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

MelvinBot commented Apr 9, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 9, 2026

Uh oh!

GCyganek commented Apr 9, 2026

Uh oh!

MelvinBot commented Apr 9, 2026

Uh oh!

rushatgabhane commented Apr 9, 2026

Uh oh!

MelvinBot commented Apr 9, 2026

Uh oh!

melvin-bot Bot commented Apr 9, 2026

Uh oh!

truph01 commented Apr 13, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants