Allow docking/building of mercies on carriers and air staging.#7135
Allow docking/building of mercies on carriers and air staging.#7135Nuggets75 wants to merge 7 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughRemoves the ChangesDAA0206 unit updates
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
needed for carrier deploy command to work
Tracking radius 0.5 -> 1.25 (bomber default) This doesn't work because of a bug in target priorities causing parentheses-using expressions to not be parsed properly, thus the unit does not have ALLUNITS in priorities so it will not target units that aren't T1-T3 structures. Set the priorities by hotkey to get them to work.
|
I tested it and found that nothing actually worked. I implemented the proposed changes of docking in air staging and building in carriers, but this necessarily comes with the side effect of mercy recharging fuel while on the ground. It's the standard 1s fuel per 2s landed time since that rate is multiplied by air staging when refueling, and the unit needs to refuel fully to leave air staging, so a low base refuel rate is unacceptable. I also needed to add the guard order for mercies to be able to leave carriers using the deploy command, which issues a guard (assist) command on the ground where you click the deploy order. Since it can now refuel, I thought it made sense to add the patrol ability. When I was testing patrol, I discovered that it wasn't working because of a long target check interval, low tracking radius, and missing |
Intended Change
Remove the CANNOTUSEAIRSTAGING category from the Mercy (DAA0206) so it can use air staging facilities and aircraft carriers, like most other air units.
Reasoning
Since the mercy rework, the mercy is now an anti t1/t2 army / structure / buildpower unit and no longer a snipe-unit so I see no reason to lock it out of carriers. I believe the main reason it was locked out was to limit their attack range with low amount of fuel before the rework. Now the mercy, while good, has an incredibly small window of opportunity that can be expanded with this change.
Expected behavior
The Mercy can now land on air staging and dock on / be built by aircraft carriers. No change to its health, damage, cost, build time, or any other stat.
Summary by CodeRabbit
Gameplay Changes
Documentation