feat(ingress): expose helm_release_name_override on nginx_gateway_fabric#343
Open
sanmesh-kakade wants to merge 3 commits intomainfrom
Open
feat(ingress): expose helm_release_name_override on nginx_gateway_fabric#343sanmesh-kakade wants to merge 3 commits intomainfrom
sanmesh-kakade wants to merge 3 commits intomainfrom
Conversation
Add a `helm_release_name_override` advanced spec field to the AWS, Azure, GCP, and OVH nginx_gateway_fabric modules so users can pin a stable Helm release name. The utility module reads this field directly from var.instance.spec; no main.tf passthrough needed. Empty/unset preserves the existing truncated-name behavior, so existing deployments see no state diff. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add JSON-schema pattern (DNS-1123 label) and maxLength: 34 on the helm_release_name_override field across AWS/Azure/GCP/OVH modules. Includes x-ui-error-message and placeholder so the UI surfaces a clear error before submit. Pairs with the TF-side validation in facets-utility-modules#36. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add proxy_{connect,read,send}_timeout (default 60s) at the instance level and
per-rule nginx_timeouts overrides on all four nginx_gateway_fabric_* flavors
(aws, azure, gcp, ovh). Lower body_size default from 150m to 1m to match the
utility module change.
Required for workloads migrating off legacy nginx_ingress_controller, which
exposed these as per-ingress annotations.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helm_release_name_overridespec field to the four nginx_gateway_fabric modules (AWS, Azure, GCP, OVH). Lets users pin a stable Helm release name when the auto-derived 34-char-truncated default is undesirable (e.g. instance/namespace renames or names that collide post-truncation).var.instance.spec(see facets-utility-modules#36); no main.tf passthrough needed here.Why
Paired with the utility-module change, this gives end users the escape hatch to keep a Helm release name stable across renames or to dodge truncation collisions, without us having to hand-hold them through manual state moves.
Test plan
helm_release_name_overrideunset →terraform planshows no diff.helm_release_name_overrideset in spec → release deploys with that name.🤖 Generated with Claude Code