Skip to content

Quote PowerShell arguments that contain ", ;, & or $ #40

Open

Description

@ChrisonSimtian

Problem

quoteArg (src/runConfig.ts) only quotes values with whitespace and escapes " as \". PowerShell does not treat \" as an escape, and ;, & and $ are special there. Such values reach the build altered, or run as extra commands.

Outcome

Any parameter value reaches the build exactly as typed, in PowerShell, cmd and POSIX shells.

Acceptance criteria

  • A value with ", ;, & or $ arrives unchanged in each supported terminal
  • A value with spaces still arrives as one argument

Notes

Existed before #35. Versions (VS Code, extension, Fallout) not yet recorded. Repro is a PowerShell terminal.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions