Skip to content

Show the resolved .NET SDK version in the startup banners - #678

Merged
dennisdoomen merged 1 commit into
Fallout-build:developfrom
dennisdoomen:claude/fallout-dotnet-sdk-version-a9a0fd
Sep 25, 2026
Merged

dennisdoomen merged 1 commit into
Fallout-build:developfrom
dennisdoomen:claude/fallout-dotnet-sdk-version-a9a0fd

Conversation

@dennisdoomen

Copy link
Copy Markdown
Collaborator

What

The execution-engine and global-tool banners show the target framework moniker (e.g. .NETCoreApp,Version=v10.0), but not which installed SDK actually resolved and is running the build — so 10.0.401 vs 10.0.100 looked identical.

How

Adds EnvironmentInfo.DotNetSdkVersion (EnvironmentInfo.Platform.cs), which asks the dotnet host that launched the current process (DOTNET_HOST_PATH, falling back to DOTNET_EXE, then dotnet on PATH) for --version, returning null if it can't be determined. GetInformationalText now appends it, so both FalloutBuild's and Fallout.Cli's banners pick it up automatically:

Fallout Execution Engine version 10.4.1-preview.1 (Windows,.NETCoreApp,Version=v10.0,SDK 10.0.303)

Testing

  • dotnet build src/Fallout.Utilities/Fallout.Utilities.csproj — clean
  • dotnet test tests/Fallout.Utilities.Specs/Fallout.Utilities.Specs.csproj — 192 passed
  • ./build.ps1 --help — banner shows the SDK version, matching dotnet --version

🤖 Generated with Claude Code

@dennisdoomen
dennisdoomen requested a review from a team as a code owner September 19, 2026 13:59
@dennisdoomen dennisdoomen added enhancement New feature or request release/Stable Targets the current/stable release labels Sep 19, 2026
@dennisdoomen
dennisdoomen changed the base branch from main to develop September 19, 2026 14:01
@dennisdoomen
dennisdoomen force-pushed the claude/fallout-dotnet-sdk-version-a9a0fd branch from 6a9b3a8 to a119265 Compare September 19, 2026 14:05
@dennisdoomen
dennisdoomen marked this pull request as draft September 19, 2026 14:08
…al-tool banners

The banner only showed the target framework moniker (e.g. .NETCoreApp,Version=v10.0),
not which installed SDK actually resolved and ran it. Add EnvironmentInfo.DotNetSdkVersion,
which asks the dotnet host that launched the process (via DOTNET_HOST_PATH/DOTNET_EXE) for
its --version, and fold it into GetInformationalText so both banners show it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dennisdoomen
dennisdoomen force-pushed the claude/fallout-dotnet-sdk-version-a9a0fd branch from a119265 to e071ef9 Compare September 19, 2026 14:08
@dennisdoomen
dennisdoomen marked this pull request as ready for review September 19, 2026 14:18
@dennisdoomen
dennisdoomen merged commit d38f79a into Fallout-build:develop Sep 25, 2026
1 check passed
This was referenced Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release/Stable Targets the current/stable release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant