Repository navigation
Show the resolved .NET SDK version in the startup banners - #678
Merged
dennisdoomen merged 1 commit intoSep 25, 2026
Merged
dennisdoomen merged 1 commit into
dennisdoomen merged 1 commit into
Conversation
dennisdoomen
force-pushed
the
claude/fallout-dotnet-sdk-version-a9a0fd
branch
from
September 19, 2026 14:05
6a9b3a8 to
a119265
Compare
dennisdoomen
marked this pull request as draft
September 19, 2026 14:08
…al-tool banners The banner only showed the target framework moniker (e.g. .NETCoreApp,Version=v10.0), not which installed SDK actually resolved and ran it. Add EnvironmentInfo.DotNetSdkVersion, which asks the dotnet host that launched the process (via DOTNET_HOST_PATH/DOTNET_EXE) for its --version, and fold it into GetInformationalText so both banners show it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dennisdoomen
force-pushed
the
claude/fallout-dotnet-sdk-version-a9a0fd
branch
from
September 19, 2026 14:08
a119265 to
e071ef9
Compare
dennisdoomen
marked this pull request as ready for review
September 19, 2026 14:18
This was referenced Nov 7, 2026
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The execution-engine and global-tool banners show the target framework moniker (e.g.
.NETCoreApp,Version=v10.0), but not which installed SDK actually resolved and is running the build — so10.0.401vs10.0.100looked identical.How
Adds
EnvironmentInfo.DotNetSdkVersion(EnvironmentInfo.Platform.cs), which asks thedotnethost that launched the current process (DOTNET_HOST_PATH, falling back toDOTNET_EXE, thendotnetonPATH) for--version, returningnullif it can't be determined.GetInformationalTextnow appends it, so bothFalloutBuild's andFallout.Cli's banners pick it up automatically:Testing
dotnet build src/Fallout.Utilities/Fallout.Utilities.csproj— cleandotnet test tests/Fallout.Utilities.Specs/Fallout.Utilities.Specs.csproj— 192 passed./build.ps1 --help— banner shows the SDK version, matchingdotnet --version🤖 Generated with Claude Code