Repository navigation
Align parameter profiles and schemas with JSON values - #703
Merged
ChrisonSimtian merged 5 commits intoNov 19, 2026
Merged
ChrisonSimtian merged 5 commits into
ChrisonSimtian merged 5 commits into
Conversation
This was referenced Oct 9, 2026
Collaborator
|
@daniatic is this PR ready for review? If so, can you please take it out of draft and ping one of us so that we can give it a code review and merge it? |
daniatic
force-pushed
the
bugfix/parameter-json-contract
branch
from
November 17, 2026 13:41
e7a8338 to
92e7aea
Compare
Load a Guid and a single Enumeration value from a profile, use a generic read helper and neutral test names, replace GuidSchemaSpecs with a Verify snapshot in SchemaUtilitySpecs, and explain why types with their own JsonConverter are skipped.
daniatic
marked this pull request as ready for review
November 17, 2026 13:55
Contributor
Author
|
@ChrisonSimtian Yes, it's ready now. I've rebased it onto the latest |
ChrisonSimtian
approved these changes
Nov 18, 2026
ChrisonSimtian
left a comment
Collaborator
There was a problem hiding this comment.
See comments, generally lgtm
Collaborator
|
Thanks for your contribution @daniatic . Since this is your first PR, I'll merge it, which then unlocks your capability to merge your own PRs once they're approved by one of us maintainers. |
ChrisonSimtian
enabled auto-merge (rebase)
November 19, 2026 03:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profile values now load through the framework's JSON converters, and Guid parameters get a schema that matches the string the runtime reads.
Part of #667. Closes #701.
What changed
[JsonConverter]keep it.FalloutBuild.Guidto{"type": "string", "format": "guid"}, and the schema serializer writes LF line endings.Verification
ParameterProfileSpecswrites real profile files and loads Enumeration values, enum names and numbers, Guids, a value through a declared[JsonConverter], and a named profile overriding the default.SchemaUtilitySpecs.TestGuidBuildsnapshots the schema for Guid, nullable Guid, Guid array and a nested Guid field. Another test checks the schema contains no CRLF.Fallout.Build.Specstests pass on Windows with .NET SDK 10.0.302.