Skip to content

Align parameter profiles and schemas with JSON values - #703

Merged
ChrisonSimtian merged 5 commits into
Fallout-build:developfrom
daniatic:bugfix/parameter-json-contract
Nov 19, 2026
Merged

ChrisonSimtian merged 5 commits into
Fallout-build:developfrom
daniatic:bugfix/parameter-json-contract

Conversation

@daniatic

@daniatic daniatic commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Profile values now load through the framework's JSON converters, and Guid parameters get a schema that matches the string the runtime reads.

Part of #667. Closes #701.

What changed

  • Profile values use the Enumeration converter and the built-in string enum converter, including nullable values and arrays. Types with their own [JsonConverter] keep it.
  • The profile loader reads the root directory and loaded profiles from the bound build instead of the static FalloutBuild.
  • The schema maps Guid to {"type": "string", "format": "guid"}, and the schema serializer writes LF line endings.

Verification

  • ParameterProfileSpecs writes real profile files and loads Enumeration values, enum names and numbers, Guids, a value through a declared [JsonConverter], and a named profile overriding the default.
  • SchemaUtilitySpecs.TestGuidBuild snapshots the schema for Guid, nullable Guid, Guid array and a nested Guid field. Another test checks the schema contains no CRLF.
  • All 262 Fallout.Build.Specs tests pass on Windows with .NET SDK 10.0.302.

@ChrisonSimtian

Copy link
Copy Markdown
Collaborator

@daniatic is this PR ready for review? If so, can you please take it out of draft and ping one of us so that we can give it a code review and merge it?
Thanks

@ChrisonSimtian ChrisonSimtian added this to the v10.5 milestone Nov 16, 2026
@daniatic
daniatic force-pushed the bugfix/parameter-json-contract branch from e7a8338 to 92e7aea Compare November 17, 2026 13:41
Load a Guid and a single Enumeration value from a profile, use a generic read helper and neutral test names, replace GuidSchemaSpecs with a Verify snapshot in SchemaUtilitySpecs, and explain why types with their own JsonConverter are skipped.
@daniatic
daniatic marked this pull request as ready for review November 17, 2026 13:55
@daniatic
daniatic requested a review from a team as a code owner November 17, 2026 13:55
@daniatic

Copy link
Copy Markdown
Contributor Author

@ChrisonSimtian Yes, it's ready now. I've rebased it onto the latest develop.

@ChrisonSimtian ChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, generally lgtm

@ChrisonSimtian ChrisonSimtian added Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved and removed needs-triage labels Nov 18, 2026
@ChrisonSimtian

Copy link
Copy Markdown
Collaborator

Thanks for your contribution @daniatic . Since this is your first PR, I'll merge it, which then unlocks your capability to merge your own PRs once they're approved by one of us maintainers.
Happy coding :-)

@ChrisonSimtian
ChrisonSimtian enabled auto-merge (rebase) November 19, 2026 03:12
@ChrisonSimtian
ChrisonSimtian merged commit f997c1a into Fallout-build:develop Nov 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guid parameters generate an object schema although profiles read GUID strings

2 participants