Skip to content

XorBinaryFuse: throw on failure #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 1 commit into from
Jan 19, 2026
+9 −18
Merged

XorBinaryFuse: throw on failure #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions fastfilter/src/main/java/org/fastfilter/xor/XorBinaryFuse16.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,9 @@ private void addAll(long[] keys) {

if (hashIndex > 100) {
// if construction doesn't succeed eventually,
// then there is likely a problem with the hash function
// let us not crash the system:
for(int i = 0; i < fingerprints.length; i++) {
fingerprints[i] = (short)0xFFFF;
}
return;
// then there is likely a problem with the hash function.
// It's better fail that either produce non-functional or incorrect filter.
throw new IllegalArgumentException("could not construct filter");
}
// use a new random numbers
seed = Hash.randomSeed();
Expand Down
9 changes: 3 additions & 6 deletions fastfilter/src/main/java/org/fastfilter/xor/XorBinaryFuse32.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,9 @@ private void addAll(long[] keys) {

if (hashIndex > 100) {
// if construction doesn't succeed eventually,
// then there is likely a problem with the hash function
// let us not crash the system:
for (int i = 0; i < fingerprints.length; i++) {
fingerprints[i] = (int) 0xFFFFFFFF;
}
return;
// then there is likely a problem with the hash function.
// It's better fail that either produce non-functional or incorrect filter.
throw new IllegalArgumentException("could not construct filter");
}
// use a new random numbers
seed = Hash.randomSeed();
Expand Down
9 changes: 3 additions & 6 deletions fastfilter/src/main/java/org/fastfilter/xor/XorBinaryFuse8.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,9 @@ private void addAll(long[] keys) {

if (hashIndex > 100) {
// if construction doesn't succeed eventually,
// then there is likely a problem with the hash function
// let us not crash the system:
for(int i = 0; i < fingerprints.length; i++) {
fingerprints[i] = (byte)0xFF;
}
return;
// then there is likely a problem with the hash function.
// It's better fail that either produce non-functional or incorrect filter.
throw new IllegalArgumentException("could not construct filter");
}
// use a new random numbers
seed = Hash.randomSeed();
Expand Down