Add config hot-reloading #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
When reloading the config, the reaper thread will disable optimisations then re-enable them while holding a write lock. However, |
This prevents a potential race condition for when the reaper thread reloads the config
Contributor
Author
|
Good point - I'd assumed that to be the case, but forgot that it was only the dbus single-threaded message queue that was protecting that race condition before. 4612533 should resolve that and passes the tests. |
mdiluz
commented
May 24, 2019
| SD_BUS_VTABLE_UNPRIVILEGED), | ||
| SD_BUS_VTABLE_END | ||
| }; | ||
| static const sd_bus_vtable gamemode_vtable[] = |
Contributor
Author
There was a problem hiding this comment.
Note this keeps getting changed by slightly differing clang-format versions. Perhaps we can do something about that eventually...
afayaz-feral
pushed a commit
that referenced
this pull request
May 26, 2020
Add config hot-reloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up two new ways to refresh the current configuration. For safety, if GameMode is active it tears down the current optimizations on both system and clients, swaps out to a new config, and then rebuilds the optimizations.
The changes provide two ways to do this:
inotifyfor file changes, new config files, or moved and deleted config files. Currently uses the reaper thread to check the inotify file descriptor for updates.RefreshConfigdbus interface (not exposed ingamemode_client.hfor now).The dbus interface is implemented as a fallback, although perhaps an argument could be made that "supervisor" clients should be allowed to call this if ever needed, and a command line argument to
gamemodedcould be implemented alongside that.