Unify privileged group configuration between pam, systemd, & polkit #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that #339 added a sysusers.d config file that creates a
gamemodegroup, but thewith-pam-groupoption could be different, and the polkit policies aren't scoped by any group.This PR adds
with-privileged-groupwhich unifies all privileged group configuration into one option, and scopes the polkit policies so that you must be a part of this group to runcpugovctl&gpuclockctl.This PR also adds
with-systemd-user-unitandwith-systemd-groupwhich default to true, but can be set to false to avoid installing systemd configs if they aren't necessary for the target platform.The
with-pam-groupoption has also been removed and renicing support is now enabled by default, but can be disabled by settingwith-pam-renicingto false.