Refactor bodyXML → bodyTree Go transformer to use internalComponents format only#115
Merged
Conversation
lokendersinghft
force-pushed
the
fix/UPPSF-6457
branch
from
e1ed7d8 to
3857d9a
Compare
lokendersinghft
force-pushed
the
fix/UPPSF-6457
branch
from
4581f21 to
fd4b85c
Compare
tsvetko24
approved these changes
Oct 16, 2025
…XML-to-content-tree transformer
lokendersinghft
force-pushed
the
fix/UPPSF-6457
branch
from
fd4b85c to
db19ef4
Compare
epavlova
approved these changes
Oct 16, 2025
Contributor
There was a problem hiding this comment.
suggestion (non-blocking): For future iterations - the "kitchen sink" test case is a good one, gathering in one document all kinds of body elements. We may re-introduce it when the Go transformers are more stable.
Co-authored-by: Elitsa Pavlova <epavlova@users.noreply.github.com>
epavlova
approved these changes
Oct 16, 2025
todor-videv1
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the bodyXML → bodyTree Go transformer to support only the bodyXML format stored in the internalComponents collection, removing support for the format returned by the internal-content-api. The transformer is intended for use in Content Tree API.
This update ensures that the generated bodyTree output more closely matches the content-tree expected to be published from Spark.
Jira --> https://financialtimes.atlassian.net/browse/UPPSF-6457