Conversation
| interface FlourishReference extends Reference { | ||
| referencedType: "flourish" | ||
| flourishType: string | ||
| layoutWidth: "" | "full-grid" |
There was a problem hiding this comment.
Interestingly in our content pipeline API we transform this into a boolean (fullGrid: true). Should we do the same here? Or are we trying to be consistent with other things that have this? (Layouts?)
There was a problem hiding this comment.
Layout values:
full-grid, fullGrid, inset-left, true.
I'm pretty sure full-grid/fullGrid means different things for all instances.
There was a problem hiding this comment.
I think in general we have three different "widths":
inset-left(floated in the article)- the width of the article copy (which is probably the default)
- bleeding outside the article copy
Ideally I think we have a single property (layoutWidth) for anythig that can have different widths, and three options for what they could be.
There was a problem hiding this comment.
Okay, maybe:
""= normal width (the width of the article copy)inset-left= inset left (for things that allow it)full-grid= bleeds to the full width of the grid
I think that works and makes sense. So I think:
- keep this as is
- CardLayout when we do it should follow the same pattern.
- Our CP content pipeline API can keep it as a string (and change it to boolean if it needs to in the JSX)
Gosh that was a journey.
2 participants
These are all properties that are available on the tag at the moment:
<ft-content type=\"http://www.ft.com/ontology/content/Content\" url=\"http://api.ft.com/content/1760409\" alt=\"\" data-asset-type=\"flourish\" data-embedded=\"true\" data-flourish-type=\"story\" data-layout-width=\"\" data-time-stamp=\"\" id=\"1760409\"></ft-content>