Add missing build dependencies + package-lock.json#4
Merged
Merged
Conversation
chee
suggested changes
Jan 5, 2023
Contributor
chee
left a comment
chee
left a comment
There was a problem hiding this comment.
these dependencies are in https://github.com/Financial-Times/content-tree/blob/main/tools/generate-typescript/package.json#L16-L20
maybe we should add workspaces: ["tools/*"] instead of this to the root pkg?
Collaborator
Author
|
Ahh, yes that makes sense! |
So we can npm install at the top level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.