Support text nodes#98
Merged
Merged
Conversation
We have a few use cases where we are publishing bodies with text content: - Some articles have trailing text before the body tag closes (we were previously handling this in the from-bodyxml transformer, but it was a hack) - FT Events publish a body without any tags i.e. just text - CCC fallbacks and Clip transcripts currently publish a body with just text There's not a strong reason not to support Text as a valid child of Body (despite the fact Spark doesn't typically allow it), so let's allow it.
adgad
force-pushed
the
support-text-nodes
branch
from
b510459 to
001cba8
Compare
epavlova
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a few use cases where we are publishing bodies with text
content:
previously handling this in the from-bodyxml transformer, but it was a
hack)
text
There's not a strong reason not to support Text as a valid child of Body
(despite the fact Spark doesn't typically allow it), so let's allow it.
Other changes
Some minor tweaks and fixes to some of our tests and fixtures