Merged
Conversation
yau-wd
requested review from
0xi4o,
HenryHengZJ,
henry-heng-wd,
igor-magun-wd and
natan-hoppe-workday
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the iframe embedding security headers by implementing Content-Security-Policy (CSP) and X-Frame-Options, while also changing the default allowed origins from '*' to ''self''. Feedback includes correcting the CSP frame-ancestors directive to use space-separated values instead of comma-separated ones to ensure browser compatibility. Additionally, it is recommended to throw an error if the IFRAME_ORIGINS environment variable is missing rather than falling back to a default, ensuring explicit security configuration.
Contributor
|
need to verify does it bring any breaking changes for exsitng users using chatembed |
Contributor
Author
|
@HenryHengZJ, I’ve added the requested test screenshots in Jira. |
igor-magun-wd
approved these changes
Apr 13, 2026
HenryHengZJ
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLOWISE-147
Resolves a clickjacking vulnerability where the application could be embedded in iframes on any domain, allowing potential UI redressing attacks on authenticated users.