Added 'gen_for_package:true/false' param to support asset generation for a package#213
Closed
urvesh-open wants to merge 2 commits into
Closed
Added 'gen_for_package:true/false' param to support asset generation for a package#213urvesh-open wants to merge 2 commits into
urvesh-open wants to merge 2 commits into
Conversation
Member
|
@urvesh-open Is the pr purpose the same? #162 |
Author
Oops. Yes @wasabeef it is solving the same feature request only the way of implementation is different in both the PRs |
Author
Member
|
@urvesh-open |
Author
Got it. Will keep it open |
This was referenced May 20, 2022
Merged
Member
|
@urvesh-open |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why fix is required?
Currently if we use fluttergen then the asset path generated won't work for packages as it expects assets path from
packages/<package_name>/<asset_path>What is changed/added?
Added flutter package support:
gen_for_package:trueto the fluttergen config it will generate assets with path that can be resolved in a package.