Skip to content

πŸ› Handles root directory assets#471

Merged
AlexV525 merged 6 commits into
FlutterGen:mainfrom
AlexV525:fix/gen-root-assets
Mar 8, 2024
Merged

πŸ› Handles root directory assets#471
AlexV525 merged 6 commits into
FlutterGen:mainfrom
AlexV525:fix/gen-root-assets

Conversation

@AlexV525

@AlexV525 AlexV525 commented Mar 6, 2024

Copy link
Copy Markdown
Member

What does this change?

Assets under the root directory are not handled before.

Fixes #69 🎯

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@codecov

codecov Bot commented Mar 7, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 98.35%. Comparing base (2b58197) to head (587175e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   98.34%   98.35%   +0.01%     
==========================================
  Files          21       21              
  Lines         724      730       +6     
==========================================
+ Hits          712      718       +6     
  Misses         12       12              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@AlexV525 AlexV525 force-pushed the fix/gen-root-assets branch from 4d21d61 to a78325d Compare March 7, 2024 02:48
@AlexV525 AlexV525 marked this pull request as ready for review March 7, 2024 03:17
@AlexV525 AlexV525 merged commit 4fe0b5c into FlutterGen:main Mar 8, 2024
@AlexV525 AlexV525 deleted the fix/gen-root-assets branch March 8, 2024 10:09
@wasabeef wasabeef added this to the 5.5.0+1 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support arbitrary files

2 participants