Skip to content

Update dependency#626

Closed
CaoGiaHieu-dev wants to merge 10 commits into
FlutterGen:mainfrom
CaoGiaHieu-dev:main
Closed

Update dependency#626
CaoGiaHieu-dev wants to merge 10 commits into
FlutterGen:mainfrom
CaoGiaHieu-dev:main

Conversation

@CaoGiaHieu-dev

Copy link
Copy Markdown

What does this change?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #625 🎯

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@AlexV525

AlexV525 commented Jan 8, 2025

Copy link
Copy Markdown
Member

I tried to upgrade it before, and it was caused by another package. Please fix all integrations first.

@codecov

codecov Bot commented Jan 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (33ff3df) to head (4523453).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files          21       21           
  Lines         822      822           
=======================================
  Hits          806      806           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CaoGiaHieu-dev

Copy link
Copy Markdown
Author

@AlexV525 hi . can you check this again

@AlexV525 AlexV525 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert not relevant changes.

Comment thread examples/example/pubspec.yaml Outdated
Comment thread examples/example/pubspec.yaml Outdated
Comment thread examples/example/pubspec.yaml Outdated
Comment thread examples/example_resources/pubspec.yaml Outdated
Comment thread examples/example_resources/pubspec.yaml Outdated
Comment thread packages/core/pubspec.yaml Outdated
Comment thread packages/core/pubspec.yaml Outdated
Comment thread packages/core/pubspec.yaml Outdated
Comment thread packages/runner/pubspec.yaml Outdated
Comment thread packages/runner/pubspec.yaml Outdated
@CaoGiaHieu-dev

Copy link
Copy Markdown
Author

Please revert not relevant changes.

Fixed .

Comment thread examples/example/pubspec.yaml Outdated
@AlexV525

AlexV525 commented Jan 9, 2025

Copy link
Copy Markdown
Member

I've taken a deeper look at this request, it seems to be covered by #615 already. The only thing we might do is upgrade the package:lottie in the example.

@CaoGiaHieu-dev

Copy link
Copy Markdown
Author

I've taken a deeper look at this request, it seems to be covered by #615 already. The only thing we might do is upgrade the package:lottie in the example.

could you take a look on my issue . because it was said that flutter_gen still using 2.x.x that make a confict with freezed (or other) package .

@AlexV525

AlexV525 commented Jan 9, 2025

Copy link
Copy Markdown
Member

could you take a look on my issue . because it was said that flutter_gen still using 2.x.x that make a confict with freezed (or other) package .

This is because #615 is not yet published. You shall not see related issues by using the dependency on the main branch.

@CaoGiaHieu-dev

Copy link
Copy Markdown
Author

could you take a look on my issue . because it was said that flutter_gen still using 2.x.x that make a confict with freezed (or other) package .

This is because #615 is not yet published. You shall not see related issues by using the dependency on the main branch.

oh . in that case it could resolve my issue without this pr . feel free to close this .
Thank you for your time

@AlexV525

AlexV525 commented Jan 9, 2025

Copy link
Copy Markdown
Member

Thanks for the contribution anyway!

@AlexV525 AlexV525 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Package Dependency

2 participants