Skip to content

Logitech C270 support #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sorig wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −12
Open

Logitech C270 support #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98dad29
Camera initialization: extend timeout and add retry mechanism
sorig Jan 16, 2026
45ecbf7
image-lib: allow decompression warnings
sorig Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions builtin-programs/camera/usb.folk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,17 +203,25 @@ $camc code {
}

$camc proc cameraFrameJpeg {Camera* camera} CameraBuffer {
struct timeval timeout;
timeout.tv_sec = 1;
timeout.tv_usec = 0;
fd_set fds;
FD_ZERO(&fds);
FD_SET(camera->fd, &fds);
int r = select(camera->fd + 1, &fds, 0, 0, &timeout);
// printf("r: %d\n", r);
if (r == -1) quit("select");
// Retry select() up to 5 times with 2 second timeout each
// Some cameras need time to start streaming
int r = 0;
for (int attempt = 0; attempt < 5 && r == 0; attempt++) {
struct timeval timeout;
timeout.tv_sec = 2;
timeout.tv_usec = 0;
fd_set fds;
FD_ZERO(&fds);
FD_SET(camera->fd, &fds);
r = select(camera->fd + 1, &fds, 0, 0, &timeout);
if (r == -1) quit("select");
if (r == 0 && attempt < 4) {
fprintf(stderr, "camera/usb: select timeout on fd %d, retry %d/4\n",
camera->fd, attempt + 1);
}
}
if (r == 0) {
FOLK_ERROR("selection failed of fd %d\n", camera->fd);
FOLK_ERROR("selection failed of fd %d after 5 attempts\n", camera->fd);
}

FOLK_ENSURE(camera_capture(camera) != 0);
Expand Down
11 changes: 9 additions & 2 deletions builtin-programs/image-lib.folk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,15 @@ $cc proc jpegDecompressGray {Jpeg jpeg int width int height int uniq} Image {
int ret = tjDecompress2(handle, jpeg.start, jpeg.length,
dest.data, width, 0, height, TJPF_GRAY, 0);
if (ret != 0) {
tjDestroy(handle);
FOLK_ERROR("cameraDecompressGray: Decompression failed: %s\n", tjGetErrorStr());
// Check if this is just a warning (e.g., "extraneous bytes before marker")
// or a fatal error. Warnings are common with webcam MJPEG streams.
int errCode = tjGetErrorCode(handle);
if (errCode == TJERR_FATAL) {
tjDestroy(handle);
FOLK_ERROR("cameraDecompressGray: Decompression failed: %s\n", tjGetErrorStr());
}
// For warnings, continue with the (possibly partially corrupted) image
// fprintf(stderr, "cameraDecompressGray: Warning: %s\n", tjGetErrorStr());
}

tjDestroy(handle);
Expand Down