Skip to content

fix(replaceFieldOperator): disallow to pass null because it will emulate instead to remove the operator#911

Merged
Scra3 merged 5 commits intomainfrom
disallow-to-pass-null
Jan 18, 2024
Merged

fix(replaceFieldOperator): disallow to pass null because it will emulate instead to remove the operator#911
Scra3 merged 5 commits intomainfrom
disallow-to-pass-null

Conversation

@Scra3
Copy link
Member

@Scra3 Scra3 commented Jan 18, 2024

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@Scra3
Copy link
Member Author

Scra3 commented Jan 18, 2024

Scra3 and others added 3 commits January 18, 2024 11:17
Co-authored-by: Morgan PERRE <morganperre@gmail.com>
@Scra3 Scra3 force-pushed the disallow-to-pass-null branch from f129e83 to 1a3d85d Compare January 18, 2024 11:10
Copy link
Contributor

@Thenkei Thenkei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ✅ Code review
  • ✅ Automatic tests
    • ✅  Unit tests
  • ✅ Manual tests
  • ✅ PR title
  • ✅ PR linked to the clickup task

});

test('replaceFieldOperator() should throw if no handler is given', () => {
test('should crash', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test('should crash', async () => {

expect(() => newBooks.replaceFieldOperator('title', 'StartsWith', null)).toThrow(
'replaceBy handler is required',
);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
});

Co-authored-by: Morgan PERRE <morganperre@gmail.com>
@Scra3 Scra3 force-pushed the disallow-to-pass-null branch from 1a3d85d to 70ba956 Compare January 18, 2024 11:21
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 70ba956 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 99.0%.

View more on Code Climate.

@Scra3 Scra3 merged commit bf0c105 into main Jan 18, 2024
@Scra3 Scra3 deleted the disallow-to-pass-null branch January 18, 2024 13:10
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.6.74 🎉

The release is available on example@1.6.74

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.36.14 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.57 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.40.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.92 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.56 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.68 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.81 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.25.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.6.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants