Skip to content

Conversation

@matthv
Copy link
Member

@matthv matthv commented Dec 23, 2025

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Dec 23, 2025

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.05%.

Modified Files with Diff Coverage (5)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
...er/decorators/rename_collection/rename_collection_decorator.rb98.9%42
Coverage rating: C Coverage rating: C
...n_agent/lib/forest_admin_agent/serializer/forest_serializer.rb0.0%152
Coverage rating: A Coverage rating: A
...urce_toolkit/schema/relations/polymorphic_one_to_one_schema.rb100.0%
Coverage rating: A Coverage rating: A
...rce_toolkit/schema/relations/polymorphic_one_to_many_schema.rb100.0%
Coverage rating: A Coverage rating: A
...rce_toolkit/schema/relations/polymorphic_many_to_one_schema.rb100.0%
Total97.9%
🤖 Increase coverage with AI coding...

In the `feat/support-polymorphic-rename` branch, add test coverage for this new code:

- `packages/forest_admin_agent/lib/forest_admin_agent/serializer/forest_serializer.rb` -- Line 152
- `packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_collection/rename_collection_decorator.rb` -- Line 42

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh
Copy link

qltysh bot commented Dec 23, 2025

All good ✅

@matthv matthv force-pushed the feat/support-polymorphic-rename branch from 4982f33 to f577849 Compare January 5, 2026 10:46
DayTF
DayTF previously approved these changes Jan 6, 2026
@matthv matthv force-pushed the feat/support-polymorphic-rename branch from 1184b21 to 62c15c0 Compare January 6, 2026 15:07
@matthv matthv force-pushed the feat/support-polymorphic-rename branch from b8f1d2c to aec6c7e Compare January 7, 2026 10:29
@matthv matthv merged commit 1ee1251 into main Jan 7, 2026
58 of 71 checks passed
@matthv matthv deleted the feat/support-polymorphic-rename branch January 7, 2026 13:04
forest-bot added a commit that referenced this pull request Jan 7, 2026
# [1.21.0](v1.20.0...v1.21.0) (2026-01-07)

### Features

* support polymorphic relations in collection renaming ([#244](#244)) ([1ee1251](1ee1251))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants