Skip to content

SDKS-4714: Use empty request body in self-service session endpoint#510

Merged
spetrov merged 2 commits intodevelopfrom
SDKS-4714
Feb 11, 2026
Merged

SDKS-4714: Use empty request body in self-service session endpoint#510
spetrov merged 2 commits intodevelopfrom
SDKS-4714

Conversation

@witrisna
Copy link
Contributor

@witrisna witrisna commented Feb 5, 2026

JIRA Ticket

SDKS-4714

Description

Remove the EMPTY constant from OkHttp's RequestBody and has been replaced with "".toRequestBody().

Definition of Done Checklist:

  • Coded to standards.
  • Ensure backward compatibility.
  • API reference docs is created or updated, if applicable.
  • Unit tests are written or updated.
  • Integration tests are written, if applicable.

Remove the `EMPTY` constant from OkHttp's `RequestBody` and has been replaced with `"".toRequestBody()`.
@witrisna witrisna self-assigned this Feb 5, 2026
spetrov
spetrov previously approved these changes Feb 6, 2026
Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please update the copyright header...

Signed-off-by: Andy Witrisna <andy.witrisna@forgerock.com>
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.75%. Comparing base (13891a1) to head (16b5d06).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../org/forgerock/android/auth/selfservice/Session.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #510   +/-   ##
==========================================
  Coverage      65.75%   65.75%           
  Complexity      1764     1764           
==========================================
  Files            264      264           
  Lines           8658     8658           
  Branches         969      969           
==========================================
  Hits            5693     5693           
  Misses          2534     2534           
  Partials         431      431           
Flag Coverage Δ
unit-tests 65.75% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spetrov spetrov merged commit 2059255 into develop Feb 11, 2026
10 of 11 checks passed
@spetrov spetrov deleted the SDKS-4714 branch February 11, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants