Skip to content

Added scrollbar to Server Profiles list in MainWindow.xaml#227

Merged
jupster merged 1 commit intoFoxlider:feature/Update-1.9from
Prodigyfly:master
Jul 17, 2025
Merged

Added scrollbar to Server Profiles list in MainWindow.xaml#227
jupster merged 1 commit intoFoxlider:feature/Update-1.9from
Prodigyfly:master

Conversation

@Prodigyfly
Copy link
Copy Markdown
Contributor

Added scrollbar to Server Profiles list in MainWindow.xaml

Description

This change adds a scrollbar to the Server Profiles list in MainWindow.xaml. Previously, if the list contained many profiles, some of them were not accessible because they were outside the visible area. This update ensures that all profiles can be seen and selected by adding a scrollable container.

Motivation and Context

  • This change is necessary because users with many server profiles were unable to access all of them without resizing the window.
  • It improves usability by making all profiles visible in a structured and user-friendly way.
  • This change does not alter the core functionality of the application but enhances the user interface.

How Has This Been Tested?

  • The modification was tested by compiling the project in Visual Studio.
  • The application was run with different numbers of server profiles to verify that the scrollbar appears when necessary.
  • No performance issues or visual bugs were detected.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Added scrollbar to Server Profiles list in MainWindow.xaml
@jupster
Copy link
Copy Markdown
Collaborator

jupster commented Mar 4, 2025

Generally I'd say do it on the latest dev branch, but I think for this it should be fine. I'll look over it hopefully today if I can get a chance.

@OverlordZorn
Copy link
Copy Markdown

resolves #226

@jupster jupster self-requested a review March 5, 2025 00:23
@liamcannon
Copy link
Copy Markdown
Contributor

Apparently my reviews don't count

Copy link
Copy Markdown
Collaborator

@jupster jupster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By dropping <DropShadowEffect BlurRadius="5" RenderingBias="Performance" ShadowDepth="0"/> it no longer creates the rectangle around the server profiles. Which is followed through out FASTER.

Once that is added back should be good to approve.

<!--Menu Column - Server Profiles-->
<StackPanel Grid.Row="1">
<StackPanel.Effect>
<DropShadowEffect BlurRadius="5" RenderingBias="Performance" ShadowDepth="0"/>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by dropping <DropShadowEffect BlurRadius="5" RenderingBias="Performance" ShadowDepth="0"/> it no longer creates a lovely rectangle around the server profiles.
IE.
68747470733a2f2f696d6775722e636f6d2f44384c71534f362e706e67

Other then that looks good 🏅

@jupster jupster changed the base branch from master to feature/Update-1.9 July 17, 2025 09:06
@jupster jupster merged commit ebdb2c5 into Foxlider:feature/Update-1.9 Jul 17, 2025
@jupster jupster mentioned this pull request Jul 25, 2025
7 tasks
jupster added a commit that referenced this pull request Jul 25, 2025
Update version and clarify menu labels (#234)
Update MainWindow.xaml (#227)
Hotfix/Code clean, .Net8 , Workflow, (#243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants