Added scrollbar to Server Profiles list in MainWindow.xaml#227
Merged
jupster merged 1 commit intoFoxlider:feature/Update-1.9from Jul 17, 2025
Merged
Added scrollbar to Server Profiles list in MainWindow.xaml#227jupster merged 1 commit intoFoxlider:feature/Update-1.9from
jupster merged 1 commit intoFoxlider:feature/Update-1.9from
Conversation
Added scrollbar to Server Profiles list in MainWindow.xaml
Collaborator
|
Generally I'd say do it on the latest dev branch, but I think for this it should be fine. I'll look over it hopefully today if I can get a chance. |
|
resolves #226 |
liamcannon
approved these changes
Apr 26, 2025
Contributor
|
Apparently my reviews don't count |
jupster
requested changes
Apr 26, 2025
Collaborator
jupster
left a comment
There was a problem hiding this comment.
By dropping <DropShadowEffect BlurRadius="5" RenderingBias="Performance" ShadowDepth="0"/> it no longer creates the rectangle around the server profiles. Which is followed through out FASTER.
Once that is added back should be good to approve.
| <!--Menu Column - Server Profiles--> | ||
| <StackPanel Grid.Row="1"> | ||
| <StackPanel.Effect> | ||
| <DropShadowEffect BlurRadius="5" RenderingBias="Performance" ShadowDepth="0"/> |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added scrollbar to Server Profiles list in MainWindow.xaml
Description
This change adds a scrollbar to the Server Profiles list in MainWindow.xaml. Previously, if the list contained many profiles, some of them were not accessible because they were outside the visible area. This update ensures that all profiles can be seen and selected by adding a scrollable container.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: