#PR1 Bug-Fixes#261
Open
diaverso wants to merge 3 commits into
Open
Conversation
…alization (Foxlider#115, Foxlider#131, Foxlider#167, Foxlider#238, Foxlider#242, Foxlider#251, Foxlider#254, Foxlider#255, Foxlider#259) FASTER/Models/ArmaMod.cs, FASTER/Models/SteamWebApi.cs - Foxlider#167: Show one-time warning after 3 failed retries if Steam API Key is invalid; check response.IsSuccessStatusCode in ApiCall() so errors propagate to retry logic with a meaningful reason FASTER/Models/BasicCfg.cs - Foxlider#251/Foxlider#115: PerfPreset getter always returns "Custom" so JSON deserialization called the setter and reset MaxMsgSend to 256 on every profile clone; fixed with [Newtonsoft.Json.JsonIgnore] FASTER/ViewModel/DeploymentViewModel.cs - Foxlider#254: LinkMod/DeleteLink called Directory.Delete(path, true) on symlinks, which destroyed the source mod folder; now checks FileAttributes.ReparsePoint - Foxlider#131: DeployAll() crashed when InstallPath didn't exist; added guard + user-facing error message; added UnauthorizedAccessException handler with Developer Mode / run-as-Admin guidance FASTER/ViewModel/SteamUpdaterViewModel.cs - Foxlider#242: mod.Status was set to NotComplete in the early cancellation path before any download started - Foxlider#259: Task.Factory.StartNew(async ()=>) returns Task<Task>; missing .Unwrap() caused ContinueWith to fire instantly instead of after async work; converted lambda to async + await, added .Unwrap() - Foxlider#238: NullReferenceException accessing SteamClient.Credentials.Username after SteamClient was nulled; save username before disposal Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
@jupster I did what you asked me to do. |
SonarCloud rule S2696 flags writing to static fields from instance methods. Extracted _apiKeyWarningShown write into TryShowApiKeyWarning() static method so the field is only accessed from static context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Appreciate it. Ill work to go through them when I can. |
…ash logging FASTER/Models/SteamWebApi.cs - S2699: Replace throw new Exception() with throw new HttpRequestException() so callers can catch a specific type instead of base Exception FASTER/ViewModel/SteamUpdaterViewModel.cs - S3776: Extract inner async lambda from RunModsUpdater into ProcessModDownloadAsync(ArmaMod mod) private method, reducing cognitive complexity from 36 to well below the 25 limit FASTER/App.xaml.cs - Add AppDomain.UnhandledException, DispatcherUnhandledException and TaskScheduler.UnobservedTaskException handlers that write to the debug log file — captures silent fatal crashes (e.g. native exceptions from BytexDigital.Steam during DownloadAsync) that bypass try/catch Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FASTER/Models/ArmaMod.cs, FASTER/Models/SteamWebApi.cs
FASTER/Models/BasicCfg.cs
FASTER/ViewModel/DeploymentViewModel.cs
FASTER/ViewModel/SteamUpdaterViewModel.cs
⬇️ Next: #PR2 Community-PRs