Upgrade eslint 8 > 9 by PikachuEXE · Pull Request #5777 · FreeTubeApp/FreeTube

PikachuEXE · 2024-10-01T01:47:56Z

Pull Request Type

Bugfix
Feature Implementation
Documentation
Other

Related issue

Description

Can't use --ext anymore, and using blob like ./**/*.js is very slow compared to specific folders, so only 2 folders are specified for js/vue files
Separate config files for json/yaml files due to I can't avoid recommended config from being applied on them
Draft until [New] support eslint 9 import-js/eslint-plugin-import#2996 released

Screenshots

Testing

yarn run lint
yarn run lint-json
yarn run lint-yml

Desktop

OS:
OS Version:
FreeTube version:

Additional context

PikachuEXE · 2024-10-02T01:45:22Z

Since we can switch from standard to neostandard later maybe we can just upgrade to ESLint 9 first?

ChunkyProgrammer

We should definitely try to fix: Separate config files for json/yaml files due to I can't avoid recommended config from being applied on them

Since IDEs/code editors wont be able to highlight the issues

eslint.yaml.config.mjs

eslint.json.config.mjs

absidue · 2024-10-03T15:55:59Z

eslint.config.mjs

+
+    settings: {
+      'vue-i18n': {
+        localeDir: './static/locales/{en-US,en-GB,ar,bg,ca,cs,da,de-DE,el,es,es-AR,es-MX,et,eu,fa,fi,fr-FR,gl,he,hu,hr,id,is,it,ja,ko,lt,nb-NO,nl,nn,pl,pt,pt-BR,pt-PT,ro,ru,sk,sl,sr,sv,tr,uk,vi,zh-CN,zh-TW}.yaml',


Please import the list instead of hardcoding it, so that we don't have to maintain it in multiple places. Using import activeLocales from './static/locales/activeLocales.json' with { type: 'json' } and then calling .join(',') on the imported array should work.

According to the history drop down on https://nodejs.org/api/esm.html#import-attributes the with keyword is supported in Node 21+ and in the LTS versions 18.20+ and 20.10+, so we should be fine using it.

With dynamic import, got warning (probably non issue assuming it eventually no longer Experimental

const { default: activeLocales } = await import('./static/locales/activeLocales.json', { with: { type: 'json' } })

Also static import would only cause syntax error with node 20.17.0

The reason it didn't work with the static import is because of the missing : between type and 'json'.

github-actions · 2024-10-04T16:39:11Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-10-05T02:45:59Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE · 2024-10-05T03:13:01Z

@ChunkyProgrammer config files merged
Turns out localeDir needed in all config blocks (even for json/yaml

absidue

Windows CMD doesn't interpret single quotes, so it passes them through to eslint and then eslint fails to find files that start and end with single quotes. I've suggested changes to switch to double quotes instead.

package.json

eslint.config.mjs

PikachuEXE · 2024-10-05T11:50:25Z

Updated~

* development: (55 commits) Translated using Weblate (Russian) Translated using Weblate (Japanese) fix cmd+m shortcut to minimize the window on macos and not mute the video (FreeTubeApp#5828) (FreeTubeApp#5829) Update dependabot.yml to add new eslint packages into the eslint group (FreeTubeApp#5837) Bump the babel group with 4 updates (FreeTubeApp#5831) Bump globals from 15.9.0 to 15.10.0 (FreeTubeApp#5835) Bump lefthook from 1.7.17 to 1.7.18 (FreeTubeApp#5836) Bump the eslint group with 2 updates (FreeTubeApp#5832) Bump @eslint/js from 9.11.1 to 9.12.0 (FreeTubeApp#5833) Bump @eslint/compat from 1.1.1 to 1.2.0 (FreeTubeApp#5834) Translated using Weblate (Belarusian) Translated using Weblate (Hebrew) Translated using Weblate (Chinese (Traditional Han script)) Turn `vue/no-useless-template-attributes` eslint rule back on (FreeTubeApp#5830) Translated using Weblate (Serbian) Translated using Weblate (Belarusian) Translated using Weblate (Belarusian) Translated using Weblate (Belarusian) Upgrade eslint 8 > 9 (FreeTubeApp#5777) Translated using Weblate (Belarusian) ...

PikachuEXE requested review from ChunkyProgrammer, absidue and efb4f5ff-1298-471a-8973-3d47447115dc October 1, 2024 01:47

PikachuEXE force-pushed the upgrade/eslint-9 branch from 115a182 to c4d6ea2 Compare October 2, 2024 01:21

PikachuEXE added the PR: dependencies Pull requests that update a dependency file label Oct 2, 2024

ChunkyProgrammer reviewed Oct 3, 2024

View reviewed changes

eslint.yaml.config.mjs Outdated Show resolved Hide resolved

eslint.json.config.mjs Outdated Show resolved Hide resolved

absidue reviewed Oct 3, 2024

View reviewed changes

github-actions bot added the PR: merge conflicts / rebase needed label Oct 4, 2024

PikachuEXE added 4 commits October 5, 2024 10:37

^ Upgrade eslint 8 > 9 & config

16c666a

* Update config for json to use flat config too

a2a7ab3

! Fix config for vue 2

efe709c

* Import list of locales from another file

2106782

PikachuEXE force-pushed the upgrade/eslint-9 branch from c4d6ea2 to 2106782 Compare October 5, 2024 02:45

github-actions bot removed the PR: merge conflicts / rebase needed label Oct 5, 2024

PikachuEXE added 2 commits October 5, 2024 10:52

* Use flat config when possible, remove unused stuff

035049f

* Merge config files

f1b3e48

PikachuEXE marked this pull request as ready for review October 5, 2024 03:13

FreeTubeBot enabled auto-merge (squash) October 5, 2024 03:13

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 5, 2024

absidue reviewed Oct 5, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

absidue reviewed Oct 5, 2024

View reviewed changes

eslint.config.mjs Outdated Show resolved Hide resolved

eslint.config.mjs Outdated Show resolved Hide resolved

* Remove vue 3 rules, improve imports

ab3d534

absidue approved these changes Oct 6, 2024

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Oct 6, 2024

View reviewed changes

ChunkyProgrammer approved these changes Oct 6, 2024

View reviewed changes

FreeTubeBot merged commit 89624a5 into FreeTubeApp:development Oct 6, 2024

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 6, 2024

Conversation

PikachuEXE commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Type

Related issue

Description

Screenshots

Testing

Desktop

Additional context

Uh oh!

PikachuEXE commented Oct 2, 2024

Uh oh!

ChunkyProgrammer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

absidue Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PikachuEXE Oct 5, 2024

Choose a reason for hiding this comment

Uh oh!

absidue Oct 5, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 4, 2024

Uh oh!

github-actions bot commented Oct 5, 2024

Uh oh!

PikachuEXE commented Oct 5, 2024

Uh oh!

absidue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PikachuEXE commented Oct 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

PikachuEXE commented Oct 1, 2024 •

edited

Loading

absidue Oct 3, 2024 •

edited

Loading