Skip to content

Checksum Validation Bug in account.rs #11

@Miska05

Description

@Miska05

Hey team! 👋 I was digging into the account.rs file and noticed something off with the checksum validation logic for Ethereum addresses around line 45.

Looks like the current implementation doesn’t fully handle cases where checksums aren't matching correctly. To fix this, I’d suggest using a stricter validation method that re-checks the checksum based on a standard like EIP-55. This would ensure we're catching all invalid addresses and preventing any weird edge cases from slipping through.

Proposed fix:

if !is_checksum_valid(s) {
return Err("Invalid checksum for Ethereum address. Please check again.");
}

Let me know what you think! Happy to help with the fix if needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions