refactor: replace manual mocks with mockall in producer#3192
refactor: replace manual mocks with mockall in producer#3192raushan728 wants to merge 4 commits into
Conversation
|
Thanks for the contribution! Before we can merge this, we need @raushan728 to sign the Fuel Labs Contributor License Agreement. |
PR SummaryLow Risk Overview Updates Reviewed by Cursor Bugbot for commit 39ed219. Bugbot is set up for automated code reviews on this repo. Configure here. |
xgreenx
left a comment
There was a problem hiding this comment.
Can you please apply nightly formatting?
|
Applied nightly formatting as requested. All imports are now in vertical layout format. |
|
Hey @raushan728 ! Thanks for the contribution! It's a little bit of an internal debate whether or not we should use It's not up to me alone, but that's my position. |
|
Thanks @MitchTurner. I'll wait for the team's final decision on this before making further changes. |
041a442 to
39ed219
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 39ed219. Configure here.
| pub struct MockTxPool(pub Vec<Transaction>); | ||
| // Re-export for backward compatibility during migration | ||
| #[cfg(feature = "test-helpers")] | ||
| pub use MockRelayer as MockRelayerLegacy; |
There was a problem hiding this comment.
Unused MockRelayerLegacy re-export is dead code
Low Severity
The pub use MockRelayer as MockRelayerLegacy re-export is introduced as "backward compatibility during migration" but is never referenced anywhere in the codebase. This is dead code that adds confusion without providing any value.
Reviewed by Cursor Bugbot for commit 39ed219. Configure here.


Migrated manual mock implementations in
producer/src/mocks.rstomockallto address internal TODOs and standardize testing infrastructure.