Skip to content

Document ACG Writer#4157

Merged
mathomp4 merged 20 commits intodevelopfrom
feature/wdboggs/acg_spec_writer
Oct 28, 2025
Merged

Document ACG Writer#4157
mathomp4 merged 20 commits intodevelopfrom
feature/wdboggs/acg_spec_writer

Conversation

@darianboggs
Copy link
Contributor

@darianboggs darianboggs commented Oct 28, 2025

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR documents the ACG Writer (MAPL2) in the file Apps/README_ACG_WRITER.md. It is in-repo documentation.

Related Issue

@darianboggs
Initial implementation
82c2adb
@darianboggs
Change walrus to assign and check.
5e15989
@darianboggs
Merge branch 'develop' into feature/wdboggs/acg_spec_writer
0d3ac1b
@darianboggs
I Am the Walrus. (Additional replace of :=)
edb8606
@darianboggs
Fix '-' in f-string
c20a7e9
@darianboggs
Fix empty spec file (b/c of incorrect proc name).
5a5af91
@darianboggs
Bugfixes: 1) extra space ignored, 2) IGNORECASE
b4c3d46
@darianboggs
Remove commented out (unused) code
dac4bc7
@darianboggs
Update subroutine regex
4c1ef08
@darianboggs
Improve layout for troubleshooting spec files
620aa22
@darianboggs
Merge branch 'develop' into feature/wdboggs/acg_spec_writer
45e23b5
@darianboggs
Updated ACG writer substantially
a2bfd4a
@darianboggs
Move LONG_NAME to end; left justify columns
f9c536b
@darianboggs
add docstrings; order first and last columns
d44d822
@darianboggs
Add README file for ACG Writer
5cb3c47
@darianboggs
Merge branch 'develop' into feature/wdboggs/acg_spec_writer
1a3f1f4
@darianboggs
Edit title
7730409
@darianboggs
Update documentation of the ACG Writer
9d9d2f7
@darianboggs darianboggs requested a review from mathomp4 October 28, 2025 16:24
@darianboggs darianboggs self-assigned this Oct 28, 2025
@darianboggs darianboggs requested a review from a team as a code owner October 28, 2025 16:24
@darianboggs darianboggs added 📝 Documentation Improvements or additions to documentation 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 😖 Shutdown This occurred during shutdown labels Oct 28, 2025
mathomp4
mathomp4 reviewed Oct 28, 2025
View reviewed changes
@darianboggs @mathomp4
Update Apps/README_ACG_WRITER.md
b5dac98 
Co-authored-by: Matt Thompson <matthew.thompson@nasa.gov>
@darianboggs darianboggs requested a review from mathomp4 October 28, 2025 18:23
@mathomp4 mathomp4 merged commit 6208695 into develop Oct 28, 2025
39 checks passed
@darianboggs darianboggs deleted the feature/wdboggs/acg_spec_writer branch October 28, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees

@darianboggs darianboggs

Labels

0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 📝 Documentation Improvements or additions to documentation 😖 Shutdown This occurred during shutdown

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darianboggs @mathomp4