make bit shaving work on nc4 tile space output#4190
Merged
Conversation
weiyuan-jiang
added
the
0 Diff
tclune
reviewed
Nov 20, 2025
tclune
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
This PR makes bit shaving work For nc4 format output in tile space, which matches that in gridded space.
Related Issue
Background
Bit shaving for 1d (tile-space) nc4 output is needed for GEOSldas, which routinely outputs diagnostics in 1d when running on the EASE tile space. In the past, GEOSldas has been writing binary output and applied a separate binary-to-nc4 script to generate tile-space nc4 output. With the recent addition of the EASE grid factory, GEOSldas is switching to writing tile-space output directly into nc4 via MAPL, see GEOS-ESM/GEOSldas_GridComp#144