Skip to content

ExtData2G backwards compatibility with non-CF vertical coord#4300

Merged
tclune merged 5 commits intoGEOS-ESM:developfrom
geoschem:feature/ewlundgr/extdata2g_compatibility_with_gchp
Jan 12, 2026
Merged

ExtData2G backwards compatibility with non-CF vertical coord#4300
tclune merged 5 commits intoGEOS-ESM:developfrom
geoschem:feature/ewlundgr/extdata2g_compatibility_with_gchp

Conversation

@lizziel
Copy link
Contributor

@lizziel lizziel commented Jan 9, 2026

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)
  • Tested this change with a run of GCHP

Description

This update is needed for ExtData2G compatibility with GCHP due to use of input files that are not CF-compliant. These files have vertical dimension variable with name 'lev', units 'level', and no positive attribute.

Changes are:

  1. Categorize dimensions with name lev as vertical coordinate in ExtData2G (update provided by Atanas) as an alternative criteria to CF definition of vertical coordinate.
  2. Assign positive attribute in ExtData2G for the case of vertical coordinate with no positive attribute in file and without pressure units. Do this by looking at standard_name, units, and order of dim values. Stop with error if standard_name is not level or levels, and units are not level or 1. Assumes positive:up if level values are increasing, and positive:down if decreasing.

Related Issue

None

…Data2G

This update is needed for ExtData2G compatibility with GCHP due to use
of input files that are not CF-compliant. These files have vertical
dimension variable with name 'lev', units 'level', and no positive
attribute.

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel requested a review from a team as a code owner January 9, 2026 15:54
lizziel and others added 2 commits January 9, 2026 11:02
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizziel I made some stylistic suggestions in the review. I had meant to circle back and merge the suggestions, but GitHub is not letting me do that. Please click the buttons on your end, and I'll approve.

Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@lizziel
Copy link
Contributor Author

lizziel commented Jan 9, 2026

Thanks @tclune for the suggestions!

Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault - but we need one more iteration on this now. Sorry about that.

Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@lizziel
Copy link
Contributor Author

lizziel commented Jan 12, 2026

No worries. I should have done a more thorough review and tested it before committing.

@tclune tclune self-requested a review January 12, 2026 15:19
@tclune tclune added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jan 12, 2026
@tclune tclune merged commit 8b66447 into GEOS-ESM:develop Jan 12, 2026
47 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants