ExtData2G backwards compatibility with non-CF vertical coord#4300
Merged
tclune merged 5 commits intoGEOS-ESM:developfrom Jan 12, 2026
Merged
Conversation
…Data2G This update is needed for ExtData2G compatibility with GCHP due to use of input files that are not CF-compliant. These files have vertical dimension variable with name 'lev', units 'level', and no positive attribute. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
tclune
reviewed
Jan 9, 2026
tclune
reviewed
Jan 9, 2026
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
tclune
reviewed
Jan 9, 2026
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
Contributor
Author
|
Thanks @tclune for the suggestions! |
tclune
reviewed
Jan 11, 2026
tclune
requested changes
Jan 11, 2026
Collaborator
tclune
left a comment
There was a problem hiding this comment.
My fault - but we need one more iteration on this now. Sorry about that.
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
Contributor
Author
|
No worries. I should have done a more thorough review and tested it before committing. |
tclune
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
This update is needed for ExtData2G compatibility with GCHP due to use of input files that are not CF-compliant. These files have vertical dimension variable with name 'lev', units 'level', and no positive attribute.
Changes are:
levas vertical coordinate in ExtData2G (update provided by Atanas) as an alternative criteria to CF definition of vertical coordinate.positiveattribute in ExtData2G for the case of vertical coordinate with nopositiveattribute in file and without pressure units. Do this by looking atstandard_name,units,and order of dim values. Stop with error ifstandard_nameis notlevelorlevels, and units are notlevelor1. Assumespositive:upif level values are increasing, andpositive:downif decreasing.Related Issue
None