Fix SIGFPE (integer divide by zero) in MAPL_LoadBalanceMod#4643
Merged
Conversation
Member
Author
|
CC'ing @wmputman has he saw the issue this might fix |
Member
Author
|
Per @wmputman this seems to have ... not hurt. That is, when he added this change, he did not get an FPE in MAPL anymore. The error just sort of "moved". So my guess is this was acting more like a trap. Something bad happened and the divide-by-zero here was the first place the model tripped. |
tclune
reviewed
Apr 20, 2026
tclune
reviewed
Apr 20, 2026
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
Member
Author
|
Ahh. I forgot about doing that. I need to remind myself! |
tclune
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAPL_BalanceWork4andMAPL_BalanceWork8to handleIdim == 0preventing division by zero.NumMax(and thusIdim) to be 0 (e.g. single sunlit gridpoint among processes).CHANGELOG.mdwith an entry for this fix.