Update to extdata2g compatibility with non-CF inputs#4802
Merged
Conversation
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
7 tasks
Collaborator
Author
bena-nasa
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
This PR has a minor change in the criteria for determining if a non-CF file vertical dimension is positive up or down based on lev dimension attributes when using ExtData2G. Previously
standard_namewas used. However, I discovered thatstandard_nameis not present in the processed GEOS-FP file used in GCHP. We do havelong_namepresent across all of our processed meteorology input files so made this PR to changestandard_nametolong_namefor the criteria. This should not impact GEOS users since the code block to check direction in non-CF files was introduced by me for GCHP.Related Issue
Supersedes #4787 (rebased from geoschem/MAPL fork to allow merge)