Skip to content

Update to extdata2g compatibility with non-CF inputs#4802

Merged
tclune merged 3 commits into
developfrom
feature/extdata2g-non-cf-long-name
May 7, 2026
Merged

Update to extdata2g compatibility with non-CF inputs#4802
tclune merged 3 commits into
developfrom
feature/extdata2g-non-cf-long-name

Conversation

@tclune
Copy link
Copy Markdown
Collaborator

@tclune tclune commented May 7, 2026

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR has a minor change in the criteria for determining if a non-CF file vertical dimension is positive up or down based on lev dimension attributes when using ExtData2G. Previously standard_name was used. However, I discovered that standard_name is not present in the processed GEOS-FP file used in GCHP. We do have long_name present across all of our processed meteorology input files so made this PR to change standard_name to long_name for the criteria. This should not impact GEOS users since the code block to check direction in non-CF files was introduced by me for GCHP.

Related Issue

Supersedes #4787 (rebased from geoschem/MAPL fork to allow merge)

@tclune tclune requested a review from a team as a code owner May 7, 2026 17:39
@tclune
Copy link
Copy Markdown
Collaborator Author

tclune commented May 7, 2026

@lizziel

@tclune tclune added 🪲 Bugfix This fixes a bug! 😲 Non 0 Diff The changes in this pull request are non-zero-diff. labels May 7, 2026
@tclune tclune merged commit f2bf174 into develop May 7, 2026
40 of 49 checks passed
@tclune tclune deleted the feature/extdata2g-non-cf-long-name branch May 7, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

😲 Non 0 Diff The changes in this pull request are non-zero-diff. 🪲 Bugfix This fixes a bug!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants