User request: confirm change dialog

[garrettjstevens]

This comes from discussing Havana usage with @shashankbrgowda. They sometimes want to be able to confirm a change and also know when it's been finished on the backend as well. Our idea was to have a dialog that pops up when a change is about to happen and allow the user to confirm or cancel it. Then the dialog will stay open until the change is successfully done on the backend as well (which also prevents concurrent changes).

This is a departure from the typical Google Docs-style editing that we mostly adhere to, where you make a change and it's just handled behind the scenes with no explicit confirming or saving, so maybe it would be optional behavior.

[garrettjstevens]

@shashankbrgowda, here's a branch you can try out to see generally how the behavior feels to you: 734_confirm_change_dialog

[shashankbrgowda]

It looks good but, we might have to display it for location and attribute change types only ? Its displaying the dialog when we try to add new feature as well below existing dialog

[garrettjstevens]

Yeah, that is a disadvantage to this approach, it would hard to know exactly which change types this would be good for and to keep the list of them updated. I think maybe #735 would be a better way to go.