Skip to content

Recreate swapchain on VK_SUBOPTIMAL_KHR#35

Merged
GPSnoopy merged 1 commit intoGPSnoopy:masterfrom
Flakebi:suboptimal
Feb 18, 2021
Merged

Recreate swapchain on VK_SUBOPTIMAL_KHR#35
GPSnoopy merged 1 commit intoGPSnoopy:masterfrom
Flakebi:suboptimal

Conversation

@Flakebi
Copy link
Contributor

@Flakebi Flakebi commented Feb 18, 2021

vkQueuePresentKHR can return VK_SUBOPTIMAL_KHR if the window size
changed. This should recreate the swapchain, like for
VK_ERROR_OUT_OF_DATE_KHR.

@GPSnoopy
Copy link
Owner

Shouldn't the result of vkAcquireNextImageKHR also be checked for this then?

vkQueuePresentKHR can return VK_SUBOPTIMAL_KHR if the window size
changed. This should recreate the swapchain, like for
VK_ERROR_OUT_OF_DATE_KHR.
@GPSnoopy GPSnoopy merged commit 8e88678 into GPSnoopy:master Feb 18, 2021
@Flakebi
Copy link
Contributor Author

Flakebi commented Feb 18, 2021

Thanks, that was quick!

@Flakebi Flakebi deleted the suboptimal branch February 18, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants