Skip to content

Fix Ring of Mantle re-applying Haste every tick#133

Open
guneykabel wants to merge 1 commit intoGTNewHorizons:masterfrom
guneykabel:fix/ring-of-mantle-haste-flicker
Open

Fix Ring of Mantle re-applying Haste every tick#133
guneykabel wants to merge 1 commit intoGTNewHorizons:masterfrom
guneykabel:fix/ring-of-mantle-haste-flicker

Conversation

@guneykabel
Copy link
Copy Markdown

What

The Ring of Mantle was removing and re-adding the Haste II potion effect
every single tick, even when the player already had it. This caused
unnecessary CPU overhead and FPS drops.

Now it checks if the player already has Haste with amplifier >= 1 before
applying, so the effect is only added once and left alone after that.

Testing

  • Wore the ring with mana available — Haste II applied once, no flickering
  • Removed ring — Haste removed as expected
  • Ran out of mana — Haste removed as expected
  • Used milk bucket to clear effect — ring re-applied it next tick

Fixes GTNewHorizons/GT-New-Horizons-Modpack#23501

The ring was removing and adding Haste II every single tick for no
reason, tanking FPS. Now it checks if the player already has the
effect before touching it.

Fixes GTNewHorizons/GT-New-Horizons-Modpack#23501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Botania/Ring of Mantle

1 participant