Fix Ring of Mantle re-applying Haste every tick#133
Open
guneykabel wants to merge 1 commit intoGTNewHorizons:masterfrom
Open
Fix Ring of Mantle re-applying Haste every tick#133guneykabel wants to merge 1 commit intoGTNewHorizons:masterfrom
guneykabel wants to merge 1 commit intoGTNewHorizons:masterfrom
Conversation
The ring was removing and adding Haste II every single tick for no reason, tanking FPS. Now it checks if the player already has the effect before touching it. Fixes GTNewHorizons/GT-New-Horizons-Modpack#23501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Ring of Mantle was removing and re-adding the Haste II potion effect
every single tick, even when the player already had it. This caused
unnecessary CPU overhead and FPS drops.
Now it checks if the player already has Haste with amplifier >= 1 before
applying, so the effect is only added once and left alone after that.
Testing
Fixes GTNewHorizons/GT-New-Horizons-Modpack#23501