Add aspects to GT++ Materials#1639
Open
jude123412 wants to merge 28 commits intoGTNewHorizons:masterfrom
Open
Conversation
jude123412
added
enhancement
Affects Balance
It was getting to big for the main TCHelper class
src/main/java/com/dreammaster/thaumcraft/TCMaterialAspectHelper.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Thaumcraft aspects added by GregTech currently have no reliable way to obtain them. At the moment, the only practical source is wisp farming, which is a hassle to make.
This PR introduces proper infrastructure for assigning Thaumcraft aspects to GT++ materials. It adds aspect definitions for several existing materials that previously lacked them, ensuring they can be scanned and integrated into Thaumcraft progression without relying on mob drops.
In addition to fixing the immediate availability issues, this PR establishes a clean and extensible framework so that future GT++ materials or any others can have aspects added in a consistent, maintainable way.
Here are the aspects I have assigned to various Materials. I can change it later if needed :)