Repository navigation
docs(ci): document the runtime-path fixture in the macOS adapter lane - #2312
Conversation
The macOS adapter step now prebuilds both Pi fixtures (pi-test-server and pi-test-path from the merged runtime-contract work) and exports ENGRAM_PI_TEST_PATH_BINARY alongside the server binary after the env-isolation loop, so sanitization cannot strip it; the doc replaces the stale claim about #1906 work being copied with the actual prebuild from repository source.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
dnlrsls
left a comment
There was a problem hiding this comment.
Reviewed the exact unchanged docs candidate against current main 5cde7fd. Both prebuilt fixture commands and exports after environment isolation match the workflow. All 47 CI contract tests passed on Windows/Node24; local link/source-path checks, four Bash syntax checks and diff checks passed. No native macOS execution is inferred. The new docs-only issue #2341 is approved and assigned, and fresh reference/approval/type checks passed after correcting the PR metadata. No source changes or merge performed.
Problem and result
The macOS adapter guide describes only the prebuilt Pi server and still says the runtime/PATH fixture is not integrated. The workflow already prebuilds both existing fixtures and exports both paths after sanitizing the environment.
Update only
docs/ci-macos.mdto show both build commands, the Pi test environment and the current integration boundary. No workflow, fixture, dependency, timeout or runtime changes.Linked issue (required)
Closes #2341
The merged runtime-fixture implementation is context, not the issue reference for this documentation correction. The accepted documentation scope and checks are recorded in #2341, approved and assigned to dnlrsls.
Verification
Unchanged source candidate:
a25383c776f9deb76bbc1896b72ee50a3512b9eb. Compared against current canonical main5cde7fd6dd69add08fd8f458fdf822c7828d8609..github/workflows/ci.yml.node --test .github/scripts/ci-technical-contracts.test.mjs— PASS, 47 tests, zero failures/skips, 8.844s on Windows/Node24.bash -n.git diff --check origin/main...HEAD— PASS; only one documentation file differs (8 additions/3 deletions).The original author and source commit are preserved. Fresh issue-policy validation is required for this metadata correction; hosted checks are not assumed green before they run.