Closed
Conversation
…nd binning should be done automatically
Member
Author
|
@LSchueler ready for review. 😊 |
LSchueler
reviewed
Jan 15, 2021
LSchueler
requested changes
Jan 15, 2021
Member
LSchueler
left a comment
LSchueler
left a comment
There was a problem hiding this comment.
This is a really nice convenience addition!
What do you think of moving the _chordal_to_great_circle method to a more visible place and making it public?
Appart from that, I think we are ready to merge this PR.
Member
|
I fixes some typos, so don't forget to pull. |
Member
Author
|
Strange. It was merged, but this PR says it has conflicts and can't be merged. It felt like an internal GitHub Error when I clicked on "merge" and I had to reload the page. Hope nothing was broken. Edit: after closing, it says that it was merged successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #55 #36
This PR adds a simple automatic binning routine
standard_binsto the variogram submodule.It returns an equal division from 0 to
max_distwithbin_noas number of bins. The following rules are applied:max_distis not given, it is set to one third of the box diameterbin_nois not given, it is determined by sturges' rule from the number of point combinationsYou can now call
gs.vario_estimatewithout passingbin_edges. In this case, the bin_edges will be determined as described above.