Update init_guess in variogram fitting#145
Merged
MuellerSeb merged 4 commits intodevelopfrom Mar 22, 2021
Merged
Conversation
…ckle a rare case of missing init guess values for fitting user defined models
…cale to mean(bin_center) and for var/nugget to mean(variogram)
LSchueler
reviewed
Mar 22, 2021
Member
LSchueler
left a comment
LSchueler
left a comment
There was a problem hiding this comment.
I think you're ready to merge this one! 👍
LSchueler
approved these changes
Mar 22, 2021
Member
Author
|
Ther have been some occasional fails of the CI for WIndows py35 with cibuildwheel. Let's keep an eye on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
init_guesscan now be given as a dictionary toCovModel.fit_variogramspecifying initial values given per parameter namelen_scalewill be the mean of given bin centers to get correct order of magnitude (fixing Variogram fitting does not work for 'large' coordinates? #143 and What about bin width causes models not to fit/produce results? #144)varandnuggetwill be the mean of the given variogram values to get correct order of magnitude