Skip to content

Drop Python 3.5 support and update CI#146

Merged
MuellerSeb merged 17 commits intodevelopfrom
drop_py35
Mar 26, 2021
Merged

Drop Python 3.5 support and update CI#146
MuellerSeb merged 17 commits intodevelopfrom
drop_py35

Conversation

@MuellerSeb
Copy link
Copy Markdown
Member

@MuellerSeb MuellerSeb commented Mar 22, 2021

Python 3.5 had its EOL in September 2020 and Ubuntu 16.04 LTS (where Python 3.5 was installed by default) has its End of Standard Support in April 2021. Let's drop support now.

Changes:

  • Use ModuleNotFoundError when version file could not be found (was not present in py35)
  • remove metaclass hack for py35 in CovModel
  • Use new Github action for cibuildwheel
  • update setup requirement versions for wheels built: numpy==1.19.* cython==0.29.*
  • pin version for pypi gh-action

@MuellerSeb MuellerSeb requested a review from LSchueler March 22, 2021 17:33
@MuellerSeb MuellerSeb self-assigned this Mar 22, 2021
@MuellerSeb MuellerSeb added CI/CD Refactoring Code-Refactoring needed here labels Mar 22, 2021
@MuellerSeb MuellerSeb added this to the 1.3 milestone Mar 22, 2021
@MuellerSeb
Copy link
Copy Markdown
Member Author

Windows wheels still failing because #147 is not yet merged.

@MuellerSeb MuellerSeb changed the title Drop Python 3.5 support Drop Python 3.5 support and update CI Mar 23, 2021
Copy link
Copy Markdown
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye annoying Py3.5 and welcome f-strings!!

@MuellerSeb MuellerSeb merged commit 4e28a4a into develop Mar 26, 2021
@MuellerSeb MuellerSeb deleted the drop_py35 branch March 26, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Refactoring Code-Refactoring needed here

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants